Conversation
…ounts for Docker registries hosted on Google Artifact Registry.
libraries/models/cloudharness_model/models/registry_secret_config.py
Dismissed
Show dismissed
Hide dismissed
libraries/models/cloudharness_model/models/registry_secret_config.py
Dismissed
Show dismissed
Hide dismissed
libraries/models/cloudharness_model/models/registry_secret_config.py
Dismissed
Show dismissed
Hide dismissed
libraries/models/cloudharness_model/models/registry_secret_config.py
Dismissed
Show dismissed
Hide dismissed
libraries/models/cloudharness_model/models/registry_secret_config.py
Dismissed
Show dismissed
Hide dismissed
libraries/models/cloudharness_model/models/registry_secret_config.py
Dismissed
Show dismissed
Hide dismissed
# Conflicts: # tools/deployment-cli-tools/ch_cli_tools/helm.py
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements support for authenticating with Docker registries hosted on Google Artifact Registry using service accounts. The implementation changes the registry secret configuration from a simple string to a nested object structure containing both a secret name and value, where the value is intended to hold Google Cloud service account credentials in JSON format.
Changes:
- Modified registry secret configuration model from a string to a nested
RegistrySecretConfigobject withnameandvaluefields - Added command-line parameter
--registry-secret-valueto pass service account credentials - Created a new Helm template (
registry-secret.yaml) that generates Kubernetes secrets for Docker registry authentication with hardcoded Google Artifact Registry configuration - Updated Python models and OpenAPI schema to reflect the new registry secret structure
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/deployment-cli-tools/harness-deployment | Added CLI argument for registry secret value |
| tools/deployment-cli-tools/ch_cli_tools/helm.py | Updated to handle registry secret as nested object structure |
| tools/deployment-cli-tools/ch_cli_tools/dockercompose.py | Added registry_secret_value parameter to function signatures |
| tools/deployment-cli-tools/ch_cli_tools/configurationgenerator.py | Added registry_secret_value parameter to base class |
| libraries/models/docs/RegistrySecretConfig.md | Documentation for new RegistrySecretConfig model |
| libraries/models/cloudharness_model/models/registry_secret_config.py | New Python model for registry secret configuration |
| libraries/models/cloudharness_model/models/registry_config.py | Updated to use RegistrySecretConfig instead of string |
| libraries/models/api/openapi.yaml | Added RegistrySecretConfig schema definition |
| deployment-configuration/helm/values.yaml | Updated registry.secret from string to nested object |
| deployment-configuration/helm/templates/registry-secret.yaml | New template for creating Kubernetes registry secrets |
| deployment-configuration/helm/templates/auto-deployments.yaml | Updated to reference registry.secret.name instead of registry.secret |
libraries/models/cloudharness_model/models/registry_secret_config.py
Outdated
Show resolved
Hide resolved
Add support for configuring registry secret value using CodeFresh secrets.
# Conflicts: # libraries/models/test-requirements.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
….
Closes CH-240
Implemented solution
...
How to test this PR
...
Sanity checks:
Breaking changes (select one):
breaking-changeand the migration procedure is well described abovePossible deployment updates issues (select one):
alert:deploymentTest coverage (select one):
Documentation (select one):
Nice to have (if relevant):