Skip to content

CH-240: Implements support for authentication using service accounts for Docker registries hosted on Google Artifact Registry.#837

Merged
filippomc merged 8 commits intodevelopfrom
feature/CH-240
Feb 26, 2026
Merged

CH-240: Implements support for authentication using service accounts for Docker registries hosted on Google Artifact Registry.#837
filippomc merged 8 commits intodevelopfrom
feature/CH-240

Conversation

@alxbrd
Copy link
Contributor

@alxbrd alxbrd commented Feb 25, 2026

….

Closes CH-240

Implemented solution

...

How to test this PR

...

Sanity checks:

  • The pull request is explicitly linked to the relevant issue(s)
  • The issue is well described: clearly states the problem and the general proposed solution(s)
  • In this PR it is explicitly stated how to test the current change
  • The labels in the issue set the scope and the type of issue (bug, feature, etc.)
  • The relevant components are indicated in the issue (if any)
  • All the automated test checks are passing
  • All the linked issues are included in one Sprint
  • All the linked issues are in the Review state
  • All the linked issues are assigned

Breaking changes (select one):

  • The present changes do not change the preexisting api in any way
  • This PR and the issue are tagged as a breaking-change and the migration procedure is well described above

Possible deployment updates issues (select one):

  • There is no reason why deployments based on CloudHarness may break after the current update
  • This PR and the issue are tagged as alert:deployment

Test coverage (select one):

  • Tests for the relevant cases are included in this pr
  • The changes included in this pr are out of the current test coverage scope

Documentation (select one):

  • The documentation has been updated to match the current changes
  • The changes included in this PR are out of the current documentation scope

Nice to have (if relevant):

  • Screenshots of the changes
  • Explanatory video/animated gif

…ounts for Docker registries hosted on Google Artifact Registry.
# Conflicts:
#	tools/deployment-cli-tools/ch_cli_tools/helm.py
@alxbrd alxbrd requested a review from filippomc February 25, 2026 16:24
@alxbrd alxbrd changed the title CH-240: Implements CH-240 to add support for authentication using service accounts for Docker registries hosted on Google Artifact Registry. CH-240: Implements support for authentication using service accounts for Docker registries hosted on Google Artifact Registry. Feb 25, 2026
@filippomc filippomc requested a review from Copilot February 25, 2026 16:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements support for authenticating with Docker registries hosted on Google Artifact Registry using service accounts. The implementation changes the registry secret configuration from a simple string to a nested object structure containing both a secret name and value, where the value is intended to hold Google Cloud service account credentials in JSON format.

Changes:

  • Modified registry secret configuration model from a string to a nested RegistrySecretConfig object with name and value fields
  • Added command-line parameter --registry-secret-value to pass service account credentials
  • Created a new Helm template (registry-secret.yaml) that generates Kubernetes secrets for Docker registry authentication with hardcoded Google Artifact Registry configuration
  • Updated Python models and OpenAPI schema to reflect the new registry secret structure

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
tools/deployment-cli-tools/harness-deployment Added CLI argument for registry secret value
tools/deployment-cli-tools/ch_cli_tools/helm.py Updated to handle registry secret as nested object structure
tools/deployment-cli-tools/ch_cli_tools/dockercompose.py Added registry_secret_value parameter to function signatures
tools/deployment-cli-tools/ch_cli_tools/configurationgenerator.py Added registry_secret_value parameter to base class
libraries/models/docs/RegistrySecretConfig.md Documentation for new RegistrySecretConfig model
libraries/models/cloudharness_model/models/registry_secret_config.py New Python model for registry secret configuration
libraries/models/cloudharness_model/models/registry_config.py Updated to use RegistrySecretConfig instead of string
libraries/models/api/openapi.yaml Added RegistrySecretConfig schema definition
deployment-configuration/helm/values.yaml Updated registry.secret from string to nested object
deployment-configuration/helm/templates/registry-secret.yaml New template for creating Kubernetes registry secrets
deployment-configuration/helm/templates/auto-deployments.yaml Updated to reference registry.secret.name instead of registry.secret

Copy link
Collaborator

@filippomc filippomc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@filippomc filippomc merged commit ab40421 into develop Feb 26, 2026
9 of 11 checks passed
@filippomc filippomc deleted the feature/CH-240 branch February 26, 2026 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants