Skip to content

Initialise superclasses #210

Merged
james-bruten-mo merged 6 commits intoMetOffice:mainfrom
Pierre-siddall:initialise-superclass
Mar 12, 2026
Merged

Initialise superclasses #210
james-bruten-mo merged 6 commits intoMetOffice:mainfrom
Pierre-siddall:initialise-superclass

Conversation

@Pierre-siddall
Copy link
Contributor

@Pierre-siddall Pierre-siddall commented Mar 12, 2026

PR Summary

Code Reviewer: @james-bruten-mo

Dependabot seems to have raised some uninitialised superclasses in classes which override either attributes or methods of the superclass . This PR ensures that the scoping on these overrides are correct so that the python interpreter has no doubts as to what is being overridden.

closes #209

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • This change has been tested appropriately (please describe)

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Security considerations have been addressed
  • Performance impact is acceptable

@Pierre-siddall Pierre-siddall self-assigned this Mar 12, 2026
@Pierre-siddall Pierre-siddall added the enhancement New feature or request label Mar 12, 2026
@Pierre-siddall Pierre-siddall marked this pull request as draft March 12, 2026 08:32
@Pierre-siddall Pierre-siddall marked this pull request as ready for review March 12, 2026 09:25
Copy link
Collaborator

@james-bruten-mo james-bruten-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@james-bruten-mo james-bruten-mo merged commit 2187c87 into MetOffice:main Mar 12, 2026
10 checks passed
@cameronbateman-mo cameronbateman-mo added this to the Summer 2026 milestone Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scoping issues with classes overriding attributes of a superclass

3 participants