Skip to content

CI: Add support of release branches - #6589

Open
oitel wants to merge 1 commit into
masterfrom
feature/ci_release_branch
Open

CI: Add support of release branches#6589
oitel wants to merge 1 commit into
masterfrom
feature/ci_release_branch

Conversation

@oitel

@oitel oitel commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@oitel
oitel requested a review from Grantim August 14, 2026 07:56
@oitel oitel added the full-ci run all steps label Aug 14, 2026
Comment thread docs/release_branches.md
Comment on lines +43 to +44
3. writes release notes covering only this patch, diffed against the previous release on the same
line.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it should cover changes from previous release branch, not previous commit of same release

Comment thread docs/release_branches.md
Comment on lines +31 to +32
Do not merge `master` into a release branch. A merge pulls `master`'s newer tags into the branch's
history and moves its version.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make a branch protection rule for it?

Comment on lines +10 to +14
run_id:
description: "Run holding the binding artifacts. Empty = this run."
required: false
type: string
default: ""

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems to me that downloading from release is more robust than taking artifacts from another run

Comment on lines +12 to +16
sign:
description: Sign the package before uploading
required: false
type: boolean
default: true

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why gate it?

Comment on lines +7 to +9
branches: [ master, 'release/**' ]
pull_request:
branches: [ master ]
branches: [ master, 'release/**' ]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mb make the rule more strict?

Comment on lines -9 to -10
release:
types: [ published ]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

who runs it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full-ci run all steps

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants