Skip to content

Workspaces API - order by schema fields instead of database fields #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
harminius wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Workspaces API - order by schema fields instead of database fields #565

harminius wants to merge 6 commits into from

Conversation

@harminius
Copy link
Contributor

@harminius harminius commented Jan 22, 2026

Fixes 1. and 3. in https://github.com/MerginMaps/server-private/issues/3154#issuecomment-3778290318

  • adds helper to map API field names to DB column names based on Schema
  • when invalid order param is passed error is thrown

@coveralls
Copy link

coveralls commented Jan 22, 2026 •
edited
Loading

Pull Request Test Coverage Report for Build 21283805147

Details

  • 48 of 49 (97.96%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 94.408%
Changes Missing Coverage Covered Lines Changed/Added Lines %
server/mergin/utils.py 22 23 95.65%
Totals Coverage Status
Change from base Build 21063718610: 0.04%
Covered Lines: 8137
Relevant Lines: 8619
💛 - Coveralls

MarcelGeo
MarcelGeo requested changes Jan 22, 2026
View reviewed changes
@MarcelGeo MarcelGeo changed the title API to DB fields map Workspaces API - order by schema fields instead of database fields Jan 22, 2026
@harminius harminius requested a review from MarcelGeo January 22, 2026 14:11
MarcelGeo
MarcelGeo requested changes Jan 22, 2026
View reviewed changes
varmar05
varmar05 reviewed Jan 23, 2026
View reviewed changes
@harminius
Address reviews
a8a24b1 
- create schema map in controller for each request
- put back test for invalid order param with 200
- unit test for get_schema_fields_map helper
@harminius
paginate once
b4ee9de
varmar05
varmar05 reviewed Jan 23, 2026
View reviewed changes
@harminius harminius requested a review from MarcelGeo January 23, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@varmar05 varmar05 varmar05 approved these changes

@MarcelGeo MarcelGeo Awaiting requested review from MarcelGeo

Requested changes must be addressed to merge this pull request.

Assignees

@harminius harminius

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@harminius @coveralls @MarcelGeo @varmar05