merge queue: checking #311 on main (88bfa11) - #312
Closed
mergify[bot] wants to merge 3 commits into
Closed
Conversation
The classifiers stopped at 3.12 and so did the matrix, while both internal consumers are already past it: the monorepo `engine` and `shadow-office` each declare `requires-python = "~=3.14.0"` and pin `sql-compare==0.2.0`. The library is consumed on 3.14 and tested on neither 3.13 nor 3.14. `requires-python = ">=3.10"` is an installability floor, not a support claim, and it stays unbounded on purpose: a ceiling there breaks `pip install` on every Python released after it. The classifiers are the support claim, so they are what this corrects. They only reach users on the next release; PyPI's current 0.2.0 still advertises `>=3.9` and stops at 3.12. Nothing else has to move. `python = "^3.10"` already spans both, so `poetry.lock`'s `python-versions` and `content-hash` are unchanged (`poetry check --lock` exits 0; classifiers are not hashed), and every locked dependency ships cp313 and cp314 wheels, so no leg builds from source. Free-threaded 3.14t is left out because nothing here exercises it, not because it would need different artifacts: `sql_compare` is one pure-Python module, so `poetry build` emits a single `py3-none-any` wheel that 3.14t installs unchanged. Adding that leg is its own decision. Verified on 3.13.10 and 3.14.6 in clean environments built from `poetry.lock`: ruff, ruff format, deptry and mypy --strict clean, 64 tests passing on both. The 3.14 leg prints two `SyntaxWarning: 'return' in a 'finally' block` from pluggy 1.5.0 whenever the bytecode cache is cold, which on CI is always. They are emitted while pluggy itself is compiled, before pytest installs `filterwarnings = ["error"]`, so they are noise on an exit-0 run. Bumping pluggy to 1.6.0 would silence them and belongs in its own change against the lock. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MKmEnjRuAM4NcTYxRXG3BA Change-Id: I08ce7a6db8d33895e7135f648c2afa9723ed0852
The two matrix legs added in the previous commit are advisory on their own. `.mergify.yml`'s `&CheckRuns` anchor is this repository's only merge gate: `branches/main/protection` returns no `required_status_checks`, and none of the eleven active rulesets carries one. So a red 3.13 or 3.14 leg would land silently. The ordering mirrors #299 -> #300 but not the reasoning, which is worth stating rather than assuming symmetric. Removing a check needed its own pull request first because Mergify reads its configuration from the default branch: a pull request deleting the job would still have been gated on a check that no longer reported, and could never merge. Adding one has no such deadlock. Both pull requests here are evaluated against main's configuration, which does not name the new checks, so a single atomic commit would have merged just as well. What the split actually buys is revertability. If a new leg turns out to be red on main, reverting this commit alone unblocks the repository while keeping the coverage the previous commit added; an atomic change would have to give up both. Two consequences worth knowing, neither of which ordering can avoid. Because main's configuration does not require the new checks until this lands, nothing forces either pull request of this stack to be green on 3.13 or 3.14. Both run the full five-leg matrix on their own head, so the legs are observable, but they have to be looked at before this one is merged rather than assumed. Every pull request already open when this lands keeps the check-run set from its last CI run, and no `pull_request` event fires when the base moves. `check-success=Test with Python 3.13` can therefore never go true on it, and `auto_merge_conditions: true` folds the success conditions into the queue conditions, so it cannot enter the queue to be rebased out either. Each one needs a push, a rebase or a close/reopen to pick up the new legs. Longer term, this list is a hand-maintained mirror of the job names and will want the same ceremony at 3.15. The monorepo and mergify-cli both replaced it with one aggregate job (`all-greens` / `ci-gate`) behind a single `check-success`, which is worth adopting here on its own. Note that `check-success~=^Test with Python ` is not a shortcut for it: check-success is a list attribute and `~=` matches any element, so one green leg would satisfy it while another fails. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MKmEnjRuAM4NcTYxRXG3BA Change-Id: I7054c8de8899a66bb549fbd9b29452d406e052ee
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
#311 is queued for merge on branch main (88bfa11).
This pull request has been created by Mergify to check the mergeability of #311.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
defaultfor merge:depends-on = Mergifyio/sql-compare#310[⛓️ ci: test against Python 3.13 and 3.14 #310]github-review-approved[🛡 GitHub branch protection]github-review-approved[🛡 GitHub repository ruleset ruleRequire pull request for default branch]Enforce conventional commit]:title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:👀 Review Requirements]:#approved-reviews-by>=1author = dependabot[bot]📕 PR description]:body ~= (?ms:.{48,})🔎 Reviews]:#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0🤖 Continuous Integration]:check-success=Test with Python 3.10check-success=Test with Python 3.11check-success=Test with Python 3.12check-success=semgrepRequired conditions to stay in the queue:
base=maindepends-on = Mergifyio/sql-compare#310[⛓️ ci: test against Python 3.13 and 3.14 #310]github-review-approved[🛡 GitHub branch protection]github-review-approved[🛡 GitHub repository ruleset ruleRequire pull request for default branch]label!=manual mergeEnforce conventional commit]:title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:👀 Review Requirements]:#approved-reviews-by>=1author = dependabot[bot]📕 PR description]:body ~= (?ms:.{48,})🔎 Reviews]:#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0🤖 Continuous Integration]:check-success=Test with Python 3.10check-success=Test with Python 3.11check-success=Test with Python 3.12check-success=semgrep