merge queue: checking #300 on main (fd8289d) - #303
Closed
mergify[bot] wants to merge 3 commits into
Closed
Conversation
Mergify reads its configuration from the default branch, so a pull request that removes 3.9 from the CI matrix would still be gated on a `Test with Python 3.9` check run that no longer exists, and could never merge. Drop the requirement first, on its own, exactly like #142 did before 3.8 was dropped in #140. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XkWQRxh5pfi2Fbuv3Z9wen Change-Id: I2e80afa6a0e70ac049da3512f43185a57a744e50
Python 3.9 has been end-of-life since October 2025 and no known consumer of sql-compare is still on it: the monorepo `engine` and `shadow-office` both declare `requires-python = "~=3.14.0"`. Dropping it unblocks dependencies that already require 3.10, starting with sqlparse 0.6.0. This also removes the CI workaround that existed only for 3.9. Poetry 2.4.1 needs Python >=3.10, so the job installed it under a pinned 3.12 and pointed it at the matrix interpreter with `poetry env use`. With a 3.10 floor a single `setup-python` is enough. Without `poetry env use`, though, poetry picks its interpreter off PATH, and every matrix version satisfies `python = "^3.10"` - so a wrong pick would test one version three times and stay green. The added assertion makes that fail loudly instead. `[tool.ruff] target-version` is dropped so ruff infers it from `requires-python`. It said "py312" while the floor was 3.9 and would have said it while the floor is 3.10; with `preview = true` and `UP` selected, that makes ruff raise UP040/UP046 with fixes that emit PEP 695 syntax (`type X = int`, `class Box[T]`), which is a SyntaxError on the 3.10 and 3.11 legs. Inferring keeps the two in sync permanently. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XkWQRxh5pfi2Fbuv3Z9wen Change-Id: I220426d76c471b02a2dc667a816cf2d171da0033
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
#300 is queued for merge on branch main (fd8289d).
This pull request has been created by Mergify to check the mergeability of #300.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
defaultfor merge:depends-on = Mergifyio/sql-compare#299[⛓️ ci(mergify): don't check Python 3.9 tests #299]github-review-approved[🛡 GitHub branch protection]github-review-approved[🛡 GitHub repository ruleset ruleRequire pull request for default branch]Enforce conventional commit]:title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:👀 Review Requirements]:#approved-reviews-by>=1author = dependabot[bot]📕 PR description]:body ~= (?ms:.{48,})🔎 Reviews]:#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0🤖 Continuous Integration]:check-success=Test with Python 3.10check-success=Test with Python 3.11check-success=Test with Python 3.12check-success=semgrepRequired conditions to stay in the queue:
base=maindepends-on = Mergifyio/sql-compare#299[⛓️ ci(mergify): don't check Python 3.9 tests #299]github-review-approved[🛡 GitHub branch protection]github-review-approved[🛡 GitHub repository ruleset ruleRequire pull request for default branch]label!=manual mergeEnforce conventional commit]:title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:👀 Review Requirements]:#approved-reviews-by>=1author = dependabot[bot]📕 PR description]:body ~= (?ms:.{48,})🔎 Reviews]:#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0🤖 Continuous Integration]:check-success=Test with Python 3.10check-success=Test with Python 3.11check-success=Test with Python 3.12check-success=semgrep