merge queue: checking main (bc9c489) and #12417 together - #12502
Closed
mergify[bot] wants to merge 2 commits into
Closed
merge queue: checking main (bc9c489) and #12417 together#12502mergify[bot] wants to merge 2 commits into
mergify[bot] wants to merge 2 commits into
Conversation
Every test framework recipe ends by sending the reader to the Test Insights dashboard, and each one carried its own copy of that sentence. Ten of the copies had drifted onto `https://dashboard.mergify.com/test-insights/jobs`, which is not a page — Test Insights has Prevention, Detection and Mitigation — and an eleventh named the dashboard with no link at all. #12490 has since corrected all eleven in place, so the links work today; what it could not fix is why one stale URL became ten broken links, which is that the sentence exists eleven times. So the paragraph becomes `_review-in-test-insights.mdx`, included by the recipes. The rendered text is byte-identical to what #12490 shipped; the next time that link moves it is one edit rather than eleven, and a recipe cannot quietly drift out of step with its siblings again. Shared partials are already how these files handle the Buildkite quarantine setup and the upload steps. Separately, two inline GitHub Actions examples were missing the `continue-on-error: true` that the quarantine partial they include requires: the Gradle example in the JUnit recipe and the `rake test` example in the Minitest one. Without it a failing test step ends the job before the upload step runs, so the run that most needs a report produces none — and in both files the sibling example directly above already had the line, so this was drift rather than a deliberate difference. Part of MRGFY-8720 Change-Id: I482ec81d7710f37d83dcffdf65abc029b73437fc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch main (bc9c489) and #12417 are queued together for merge.
This pull request has been created by Mergify to check the mergeability of #12417.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
defaultfor merge:github-review-approved[🛡 GitHub repository ruleset ruleRequire pull request for default branch]schedule=Mon-Fri 09:00-17:30[Europe/Paris]Enforce conventional commit]:title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:👀 Review Requirements]:#approved-reviews-by >= 2author = dependabot[bot]author = mergify-ci-bot-head ~= ^docs-agent/📕 PR description]:body ~= (?ms:.{48,})🔎 Reviews]:#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0🤖 Continuous Integration]:check-success = buildcheck-success = lintcheck-success = testcheck-success = test-broken-linkslabel = ignore-broken-linkscheck-success=Cloudflare Pages-head-repo-full-name~=^Mergifyio/Required conditions to stay in the queue:
github-review-approved[🛡 GitHub repository ruleset ruleRequire pull request for default branch]Enforce conventional commit]:title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:👀 Review Requirements]:#approved-reviews-by >= 2author = dependabot[bot]author = mergify-ci-bot-head ~= ^docs-agent/📕 PR description]:body ~= (?ms:.{48,})🔎 Reviews]:#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0🤖 Continuous Integration]:check-success = buildcheck-success = lintcheck-success = testcheck-success = test-broken-linkslabel = ignore-broken-linkscheck-success=Cloudflare Pages-head-repo-full-name~=^Mergifyio/author != dependabot[bot]author != mergify-ci-bothead ~= ^docs-agent/