feat(reading): polish nav, hub-page heroes, sidebar feedback, h2 counters#11453
Open
jd wants to merge 1 commit into
Open
feat(reading): polish nav, hub-page heroes, sidebar feedback, h2 counters#11453jd wants to merge 1 commit into
jd wants to merge 1 commit into
Conversation
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 🤖 Continuous IntegrationWonderful, this rule succeeded.
🟢 👀 Review RequirementsWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 ReviewsWonderful, this rule succeeded.
🟢 📕 PR descriptionWonderful, this rule succeeded.
|
There was a problem hiding this comment.
Pull request overview
This PR applies “reading experience” UX polish across the docs site by adjusting responsive navigation behavior, adding optional hub-page title accent styling, relocating page actions to the right sidebar, and removing inherited global H2 auto-numbering.
Changes:
- Lowered the header nav breakpoint so primary nav buttons remain visible at typical laptop widths.
- Added optional
hubAccentfrontmatter to render hub-page H1 titles using the existing section accent color. - Moved the page feedback widget into the right sidebar and removed global H2 auto-numbering (plus related opt-out CSS).
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/styles/index.css | Adds hero-accent H1 styling and removes global H2 numbering CSS. |
| src/styles/api-reference.css | Removes API-reference-specific overrides that were only needed for global numbering. |
| src/pages/changelog/index.astro | Removes changelog heading numbering overrides now made unnecessary. |
| src/pages/changelog/[slug].astro | Removes changelog detail heading numbering overrides now made unnecessary. |
| src/layouts/MainLayout.astro | Stops rendering PageFeedback in the footer slot and updates RightSidebar props. |
| src/content/docs/test-insights.mdx | Enables hubAccent on Test Insights hub page. |
| src/content/docs/merge-queue.mdx | Enables hubAccent on Merge Queue hub page. |
| src/content/docs/index.mdx | Removes no-counter classes from homepage H2s since global numbering is removed. |
| src/content/docs/ci-insights.mdx | Enables hubAccent on CI Insights hub page. |
| src/content.config.ts | Extends docs schema with optional hubAccent boolean. |
| src/components/RightSidebar/RightSidebar.astro | Adds page-actions cluster (feedback + edit link) beneath the ToC. |
| src/components/PageContent/PageContent.astro | Applies hero-accent class to the auto-rendered H1 when hubAccent is set. |
| src/components/Header/Header.astro | Lowers the breakpoint at which nav buttons are hidden. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jd
force-pushed
the
devs/jd/worktree-design/pass-c-reading-experience-polish--b39618f6
branch
from
057ea7f to
b10bec4
Compare
Member
Author
Revision history
|
jd
force-pushed
the
devs/jd/worktree-design/pass-c-reading-experience-polish--b39618f6
branch
from
b10bec4 to
a780ad6
Compare
jd
force-pushed
the
devs/jd/worktree-design/pass-c-reading-experience-polish--b39618f6
branch
from
a780ad6 to
0de5e2b
Compare
sileht
previously approved these changes
May 11, 2026
JulianMaurin
previously approved these changes
May 11, 2026
Contributor
Merge Queue Status
This pull request spent 1 hour 13 minutes 47 seconds in the queue, including 2 minutes 51 seconds running CI. Waiting for
All conditions
ReasonThe pull request #11453 has been manually updated HintIf you want to requeue this pull request, you can post a |
51 tasks
…ters Four small UX fixes for day-2 readers — users already in the docs looking for information. - Lower the top-nav breakpoint from 87em (1392px) to 68em (1088px) so the 5 nav buttons (Dashboard, Slack, Discussions, Changelog, Status) are visible at typical laptop widths. The previous breakpoint dated from when the navbar carried a logo eating the horizontal space; the logo now lives in the left sidebar. - Hub-page light heroes: /merge-queue, /ci-insights, /test-insights H1s now render in their product accent color (teal / purple / orange). Driven by a new optional `hubAccent: true` frontmatter field on the docs schema; PageContent.astro reads it and adds a `hero-accent` class to the auto-rendered H1. CSS hooks the class into the existing `--section-accent` custom property. No new copy, no screenshots, no CTAs — just an accent on the title. - Right-sidebar page-actions cluster: the right column now hosts a PageFeedback widget beneath the table of contents, giving the sidebar a purpose on short doc pages. PageFeedback is mirrored, not moved — the article-footer copy still renders for users on viewports below 82em (where the right sidebar is hidden), with a CSS rule on MainLayout hiding the footer copy when the sidebar is visible. PageMeta's existing Edit-on-GitHub link stays as the single source of truth (no duplication). - Drop the global h2 auto-numbering. The CSS counter that prefixed every h2 with 1., 2., 3. is deleted. The pattern was an Astro Starlight inheritance that doesn't fit reference / conceptual pages; sequential pages can author explicit numbering inline. The homepage h2s' `class="no-counter"` opt-outs are removed since the rule they overrode is gone. Stale `counter-increment: none` guards in changelog and api-reference styles also removed. Change-Id: Ib39618f6b4e3fc79ade43934a3d5db6faad6a551
jd
changed the title
jd
force-pushed
the
devs/jd/worktree-design/pass-c-reading-experience-polish--b39618f6
branch
from
0de5e2b to
f9ea28b
Compare
mergify
Bot
dismissed stale reviews from sileht and JulianMaurin
Pull request has been modified.
JulianMaurin
approved these changes
May 12, 2026
kozlek
approved these changes
May 12, 2026
Contributor
Merge Queue Status
Waiting for any of
All merge conditions
Required conditions to stay in the queue
|
51 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four small UX fixes for day-2 readers — users already in the docs
looking for information.
Lower the top-nav breakpoint from 87em (1392px) to 68em (1088px)
so the 5 nav buttons (Dashboard, Slack, Discussions, Changelog,
Status) are visible at typical laptop widths. The previous
breakpoint dated from when the navbar carried a logo eating the
horizontal space; the logo now lives in the left sidebar.
Hub-page light heroes: /merge-queue, /ci-insights, /test-insights
H1s now render in their product accent color (teal / purple /
orange). Driven by a new optional
hubAccent: truefrontmatterfield on the docs schema; PageContent.astro reads it and adds a
hero-accentclass to the auto-rendered H1. CSS hooks the classinto the existing
--section-accentcustom property. No new copy,no screenshots, no CTAs — just an accent on the title.
Right-sidebar page-actions cluster: the right column now hosts a
PageFeedback widget beneath the table of contents, giving the
sidebar a purpose on short doc pages. PageFeedback is mirrored,
not moved — the article-footer copy still renders for users on
viewports below 82em (where the right sidebar is hidden), with a
CSS rule on MainLayout hiding the footer copy when the sidebar
is visible. PageMeta's existing Edit-on-GitHub link stays as the
single source of truth (no duplication).
Drop the global h2 auto-numbering. The CSS counter that prefixed
every h2 with 1., 2., 3. is deleted. The pattern was an Astro
Starlight inheritance that doesn't fit reference / conceptual
pages; sequential pages can author explicit numbering inline. The
homepage h2s'
class="no-counter"opt-outs are removed since therule they overrode is gone. Stale
counter-increment: noneguardsin changelog and api-reference styles also removed.