fix: restore flex alignment for nav-group icons in sidebar#10625
Open
fix: restore flex alignment for nav-group icons in sidebar#10625
Conversation
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 🤖 Continuous IntegrationThis rule is failing.
🔴 👀 Review RequirementsThis rule is failing.
🔴 🔎 ReviewsThis rule is failing.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 📕 PR descriptionWonderful, this rule succeeded.
|
There was a problem hiding this comment.
Pull request overview
This PR fixes sidebar nav-group icon vertical alignment by restoring flex layout on the .nav-group-title h2 element, which was unintentionally reset to display: block due to all: inherit.
Changes:
- Re-applies
display: flex,align-items: center, andgapto.nav-group-title h2to ensure icons are vertically centered.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The `all: inherit` on `.nav-group-title h2` was resetting `display` to `block` (inherited from the parent button), causing icons to align to the text baseline instead of being vertically centered. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Change-Id: Ifb693f286fe2b4666c82e8b48f34e4d3fc13be06 Claude-Session-Id: 485ef05a-bcab-42bb-b918-04a964828180
jd
force-pushed
the
devs/jd/worktree-icon-align-navbar/Ifb693f286fe2b4666c82e8b48f34e4d3fc13be06
branch
from
cc490e4 to
b1ac499
Compare
sileht
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
all: inheriton.nav-group-title h2was resettingdisplaytoblock(inherited from the parent button), causing icons to align tothe text baseline instead of being vertically centered.
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com