Repository navigation
Conversation
…n I get back?" (#232) design-spacing.md §3 prescribed the page-header crumb as one plain-text dynamictext, which every wireframe and page then copied. The scaffold now builds crumbs from linkbuttons with SHOW_PAGE targets (current page alone as text). module-review.md §4c, the one LOOK question list, gains "can I get back?" and "does every tile go somewhere?". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VJgWP5vEoAsNsJYqCDMGNw
…estions (review of #371) Crumb scaffold uses the gallery classes (crumbs, btn-link, crumb-sep) and points at 18-breadcrumbs.mdl for close-page vs show-page. The LOOK questions point at design-spacing.md section 3 and wiring-sweep.md instead of restating them; the oneshot example shows a linked crumb. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VJgWP5vEoAsNsJYqCDMGNw
MendixMau
pushed a commit
that referenced
this pull request
Oct 14, 2026
…OOK asks "can I get back?" (#232) Review: independent review MERGE-AFTER-FIX — scaffold lacked separators; ~50 movable words; oneshot ✅ example still showed plain-text crumbs → crumb example matches examples/stylegallery 18-breadcrumbs.mdl (crumbs / btn-link / crumb-sep, close-page case), 40 words trimmed, LOOK questions point to their sources, oneshot example fixed, in e35c883; confirmation MERGE. Baseline +131. Open part of #232 (proposals 1 and 4 remain). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VJgWP5vEoAsNsJYqCDMGNw
Merged
5 of 7 tasks
MendixMau
added a commit
that referenced
this pull request
Oct 15, 2026
…journey controls, fixes) (#385) Lands #340 #363 #362 #355 #370 #368 #364 #365 #366 #372 #367 #371 #376 #369 #373 #377 #378 #380. Review: each constituent PR independently reviewed by a fresh agent that did not write it; merged into integration/2026-10-15 only on a MERGE verdict with green CI (per-PR Review lines in the integration merge commits). After-fix rounds: #373 (env-var cap, rename/skip-loops freshness), #377 (inline URI fallback), #378 (full-pack double count, slice content). Stub diet (#369/#378/#380) behaviour A/B, 5 reps x 2 drafting tasks + 5 retrieval probes x 3 reps: trimmed context no worse than master on every scored metric (planted STOP refused 20/20, parse failures page 2/5 vs 3/5, probes 15/15); mdl Stage 5 56,236 -> 30,647 words, baseline 75,028 -> 73,233. Full suites on c9bc073: run-tests 33/0, wave2 111 fixtures 0 failing. Field evidence: none yet for the instruments (#355 warn-only, #373/#377 read-only). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VJgWP5vEoAsNsJYqCDMGNw
Owner
Author
|
Landed on master in #385 (squash Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Direct lane
What changed and why (one paragraph):
This covers the still-open part of #232.
skills/design-spacing.md§3 prescribed the page-header crumb as one plain-textdynamictext('Home / <Area> / <Page>'). Every wireframe and page copied it, andpage-fidelity.jsscored the text crumb as correct. The scaffold now builds the crumb the way the StyleGallery does (examples/stylegallery/mdlsource/gallery/18-breadcrumbs.mdl): acrumbscontainer,btn-linklink buttons andcrumb-sepseparators. The current page, and a section that is not a page, stay plain text. A short rule adds three points:skills/module-review.md§4c owns the LOOK question list and now has two new questions. "Can I get back?" points todesign-spacing.md§3. "Does every tile go somewhere?" points towiring-sweep.mdfor whether each click does something, and asks the reviewer to judge where it lands. The ✅ example inskills/oneshot-page-structure-patterns.md(on-demand) now shows a linked crumb. This PR does not close #232: blocking on the owed list (proposal 1), the journey and seed changes (proposal 4) and the "done step" question are still open.Field evidence: taken from the issue: an 81-script Stage-5 build where every gate went green, and a user then found text-only crumbs and a menu entry that opened one record instead of a list. No field run of this PR itself yet; it changes only text in skills.
render-routing --checkin sync,test-routing-tier.sh12/12,test-render-routing.sh5/5,test-baseline-pack.sh16/16)CHANGELOG.mdline appended, crediting MendixMauBaseline words: 75,028 → 75,159 (+131, budget 80,000).
🤖 Generated with Claude Code
https://claude.ai/code/session_01VJgWP5vEoAsNsJYqCDMGNw