Repository navigation
Conversation
The test-agent brief confined writes to {{TEST_DIR}} (tests/e2e/ when
filled), while verify-module.sh, fixture-manifest.sh, journey-proof.md
and the Stage-6 artifact gate read journeys from ${JOURNEY_DIR}
(default journeys/). The brief and its workflow step now send journeys
there; agent-roles.md says how to fill {{TEST_DIR}}, which nothing
fills automatically.
Reported by joshuamoesa.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VJgWP5vEoAsNsJYqCDMGNw
#367) Only verify-module.sh and the artifact gate honour JOURNEY_DIR; fixture-manifest.sh hard-sets journeys/. Drop the override claim, say journeys stay at the root, and note in the CHANGELOG that completed stubs keep their old text (sync-project.sh --diff-completed shows it). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VJgWP5vEoAsNsJYqCDMGNw
MendixMau
changed the title
MendixMau
pushed a commit
that referenced
this pull request
Oct 14, 2026
Review: independent review MERGE-AFTER-FIX — override claim inaccurate (fixture-manifest.sh hard-sets journeys/) → docs now say journeys stay in journeys/ at the project root; completed stubs keep old text (--diff-completed shows it), in 6887f84; confirmation MERGE (reviewer's own artifact-gate claim corrected: artifact-manifest/artifact-check do honour JOURNEY_DIR; fixture-manifest is the only outlier). Baseline +66. Closes #359 (joshuamoesa). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VJgWP5vEoAsNsJYqCDMGNw
Merged
5 of 7 tasks
MendixMau
added a commit
that referenced
this pull request
Oct 15, 2026
…journey controls, fixes) (#385) Lands #340 #363 #362 #355 #370 #368 #364 #365 #366 #372 #367 #371 #376 #369 #373 #377 #378 #380. Review: each constituent PR independently reviewed by a fresh agent that did not write it; merged into integration/2026-10-15 only on a MERGE verdict with green CI (per-PR Review lines in the integration merge commits). After-fix rounds: #373 (env-var cap, rename/skip-loops freshness), #377 (inline URI fallback), #378 (full-pack double count, slice content). Stub diet (#369/#378/#380) behaviour A/B, 5 reps x 2 drafting tasks + 5 retrieval probes x 3 reps: trimmed context no worse than master on every scored metric (planted STOP refused 20/20, parse failures page 2/5 vs 3/5, probes 15/15); mdl Stage 5 56,236 -> 30,647 words, baseline 75,028 -> 73,233. Full suites on c9bc073: run-tests 33/0, wave2 111 fixtures 0 failing. Field evidence: none yet for the instruments (#355 warn-only, #373/#377 read-only). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VJgWP5vEoAsNsJYqCDMGNw
Owner
Author
|
Landed on master in #385 (squash Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Direct lane
What changed and why (one paragraph):
The test-agent brief (
agents/test-agent.md) confined writes to{{TEST_DIR}}(filled astests/e2e/). Journeys, though, are read fromjourneys/at the project root byverify-module.sh,fixture-manifest.sh,journey-proof.mdand the Stage-6 artifact gate. A test-agent that obeyed its brief wrotetests/e2e/journeys/*.journey.json, and the gate never found them. The brief's boundary and its workflow step now send journeys tojourneys/<Module>.journey.jsonand say not to relocate them.fixture-manifest.shhard-setsjourneys/whateverJOURNEY_DIRsays, so an override would leave verify green and fixtures blind.skills/agent-roles.mdnow says nothing fills{{TEST_DIR}}and how to fill it. No auto-fill was added, for two reasons. First,init-agents.shandsync-project.sh's check for untouched stubs would both have to apply it in lockstep. Second, the test directory is a project fact. A project whosetest-agent.mdis already completed keeps its old text;bin/sync-project.sh <project> --diff-completedshows the change. Closes #359. Reported by @joshuamoesa.Field evidence: taken from the issue: an existing-app project (macOS) whose Stage-6 journey row cleared only after
ln -s tests/e2e/journeys journeys. No field run of this PR itself yet; it changes only text in a brief and a skill.render-routing --checkin sync,test-routing-tier.sh12/12,test-render-routing.sh5/5)CHANGELOG.mdline appended, crediting joshuamoesaBaseline words: 75,028 → 75,094 (budget 80,000).
🤖 Generated with Claude Code
https://claude.ai/code/session_01VJgWP5vEoAsNsJYqCDMGNw