Repository navigation
Conversation
) checkpoint.sh ships at claude-hooks/bin/ and reaches ~/.claude/bin only via the opt-in install-claude-hooks.sh --basic. close-task.sh printed `checkpoint.sh --write` unconditionally. It now looks in PATH, then ~/.claude/bin, then $MXTK_ROOT/claude-hooks/bin, and prints the full path, or an install pointer with "skip: RESUME.md is the resume source". The exit code is unchanged (1 only when writes are owed). close-the-loop.md step 4 is updated to match. Fixture tests/wave2/test-close-task-checkpoint.sh: 10 cases, 7 fail on master. Closes #358 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VJgWP5vEoAsNsJYqCDMGNw
…bling path (#362 review) A HOME or toolkit path with a space broke copy-paste of the printed `<path> --write` and install-hint commands. Both are now single-quoted, with embedded ' escaped via sed for bash 3.2. The ~/.claude/bin copy (claude-hooks/bin/close-task.sh) printed a bare checkpoint.sh, though ~/.claude/bin is usually not on PATH; it now prints its sibling's full path, quoted. The fixture gains T7a-c (space in HOME, space and ' in the toolkit path, quoted install hint; each printed line is eval'd) and T8 (hooks copy): 14/14 pass, 11 fail on master. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VJgWP5vEoAsNsJYqCDMGNw
MendixMau
pushed a commit
that referenced
this pull request
Oct 14, 2026
…g it bare (#358) Review: independent review MERGE-AFTER-FIX (printed paths broke on spaces; hooks copy printed a bare name with ~/.claude/bin off PATH) → shq() quoting + sibling full path in 6164bc6; confirmation MERGE: printed line executed correctly for paths with space, $HOME, backtick, !, ', ", \. Fixture 14/14 (11 fail on master). Closes community issue #358 (joshuamoesa). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VJgWP5vEoAsNsJYqCDMGNw
Merged
5 of 7 tasks
MendixMau
added a commit
that referenced
this pull request
Oct 15, 2026
…journey controls, fixes) (#385) Lands #340 #363 #362 #355 #370 #368 #364 #365 #366 #372 #367 #371 #376 #369 #373 #377 #378 #380. Review: each constituent PR independently reviewed by a fresh agent that did not write it; merged into integration/2026-10-15 only on a MERGE verdict with green CI (per-PR Review lines in the integration merge commits). After-fix rounds: #373 (env-var cap, rename/skip-loops freshness), #377 (inline URI fallback), #378 (full-pack double count, slice content). Stub diet (#369/#378/#380) behaviour A/B, 5 reps x 2 drafting tasks + 5 retrieval probes x 3 reps: trimmed context no worse than master on every scored metric (planted STOP refused 20/20, parse failures page 2/5 vs 3/5, probes 15/15); mdl Stage 5 56,236 -> 30,647 words, baseline 75,028 -> 73,233. Full suites on c9bc073: run-tests 33/0, wave2 111 fixtures 0 failing. Field evidence: none yet for the instruments (#355 warn-only, #373/#377 read-only). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VJgWP5vEoAsNsJYqCDMGNw
Owner
Author
|
Landed on master in #385 (squash Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #358
Direct lane
What changed and why (one paragraph):
checkpoint.shdoes exist. It ships atclaude-hooks/bin/checkpoint.shand reaches~/.claude/binonly via the opt-inbin/install-claude-hooks.sh --basic. The defect was thatproject-bin/close-task.shalways printedcheckpoint.sh --writein its "Then" block, andskills/close-the-loop.mdstep 4 cited it without saying where it comes from. So a project without the hooks got a step it could not run.close-task.shnow resolves the script: PATH first, then~/.claude/bin, then$MXTK_ROOT/claude-hooks/bin(using the toolkit-root resolution the script already had). It prints the full path it found, single-quoted, so a path with spaces or a'survives copy-paste. If none is found, it printscheckpoint.sh not installed — run '<toolkit>/bin/install-claude-hooks.sh' --basic, or skip: RESUME.md is the resume source, with the install path also quoted, and prints the rest of the block. close-task.sh only prints the step and never runs it, so a missing checkpoint.sh cannot fail it. The exit code still means only "writes owed" (1) or clean (0).close-the-loop.mdstep 4 gains the same note. The~/.claude/bincopy,claude-hooks/bin/close-task.sh, also printed a barecheckpoint.sh, although~/.claude/binis usually not on PATH. It now prints its sibling's full path, quoted.Field evidence: none yet from a project run of the fix. The defect comes from the reporter's existing-app field run, where the closing agent had to skip the step with no pointer. Run from a toolkit checkout with
MXTK_ROOTunset, the fix prints'<clone>/claude-hooks/bin/checkpoint.sh' --write, exit 0.No client data anywhere in the diff
Size cap: 5 files, about 50 non-fixture lines
Test tier reached: T1. The new fixture
tests/wave2/test-close-task-checkpoint.sh project-bin/close-task.shpasses 14/14. On master it fails 11/14; the 3 that pass on master are the "carries on / exit code" cases, which must not regress. Its cases:~/.claude/bin(fake HOME)claude-hooks/bin'in the toolkit path; each printed line is eval'd to prove it runsThe existing
test-pipefail-grep-q.shalso covers close-task.sh and passes 3/3.For a changed instrument: it uses only
command -v,[ -f ],$HOMEand sed-based quoting (no${x//}, so bash 3.2 works), so the same code runs on macOS and Git Bash. Layout does not matter, because no.mprpath is involved.For a new skill: n/a
CHANGELOG.mdline appended, credited to joshuamoesa ([bug] close-task.sh and close-the-loop.md reference checkpoint.sh / docs/progress/checkpoints.md, which init-project never installs and which do not exist in the repo #358)New bug entries: n/a
🤖 Generated with Claude Code
https://claude.ai/code/session_01VJgWP5vEoAsNsJYqCDMGNw