Repository navigation
fix: sign and verify macOS beta binaries before packaging - #350
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
v0.1.44-beta.17 shipped a Darwin arm64 executable with an invalid embedded Mach-O signature. macOS terminates it with SIGKILL (Code Signature Invalid), even though release checksum and attestation match.
Fix
Ad-hoc sign and strictly verify the compiled Darwin executable before smoke testing and archiving. Prepare beta.18 release notes. Keep the release provenance policy unchanged.
Validation
--version,--help)codesign --verify --strictand--versionpassednode --test src/mendcode/script/release-index.test.mjs— 3 passedgit diff --checkpassedAfter merge, dispatch release.yml from main with the merged SHA and validate published assets and provenance.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.