Repository navigation
fix: allow prereleases from main candidates - #346
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Release run
35916028675failed inEnsure release runs from main: prerelease candidates were checked only as ancestors oforigin/dev, but beta16 was correctly promoted tomainvia squash and is not an ancestor ofdev.Solution
Allow prerelease candidates to be verified against either
origin/devororigin/main. Stable releases keep the existingmain-only guard.Verification
git diff --check— passed.HEADis an ancestor oforigin/main; the previous failed run confirmed it is not an ancestor oforigin/dev.dev..github/workflows/release.yml.Release follow-up
After this PR merges, rerun the beta16 release workflow from
mainusing source SHA670d7f60bc2f2601cca7cb0b0558f00a1dd7a4b4.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.