refactor(chat/responses): canonicalize input at the entry boundary#136
Draft
Menci wants to merge 1 commit into
Draft
refactor(chat/responses): canonicalize input at the entry boundary#136Menci wants to merge 1 commit into
Menci wants to merge 1 commit into
Conversation
Wire `ResponsesPayload.input` is `string | InputItem[]`. The HTTP/WS
entries normalize a bare-string `input` to a single synthetic
user-role message immediately on parse, so every internal reader sees
array-only input. Encoded in the type system via a new
`CanonicalResponsesPayload = Omit<ResponsesPayload, 'input'> &
{ input: ResponsesInputItem[] }`.
Plumbed through every signature past the entry: ResponsesServeGenerateArgs,
ResponsesServeCompactArgs, ResponsesAttemptInvokeArgs, ResponsesInvocation
(the gateway-internal interceptor variant — provider-package
ResponsesInvocation stays wire-shaped), ResponsesServePlan.prepared,
RewrittenResponsesPayload, expandPreviousResponseId, normalizeAssistantInputText.
Cross-protocol entries (messages/gemini translating to responses)
re-canonicalize the translated payload via the exported
`canonicalizeResponsesPayload` helper.
Removes every internal `typeof input === 'string'` branch:
expandPreviousResponseId, expandShimCompactionItems, simulateCompaction
(the shim's `originalInputItems` materialization), containsCompactionTrigger,
withInterleavedSystemDemotedToUser. Drops `materializeInput` in serve-prep
(input is already array). Drops the matching obsolete tests.
3 tasks
Menci
force-pushed
the
floway/inline-pick-into-serve
branch
from
88cd186 to
ce88d6a
Compare
Menci
force-pushed
the
floway/canonicalize-responses-input
branch
from
2789279 to
e8ea938
Compare
Menci
force-pushed
the
floway/inline-pick-into-serve
branch
from
ce88d6a to
87e1ce3
Compare
Menci
force-pushed
the
floway/canonicalize-responses-input
branch
from
e8ea938 to
1cd85a8
Compare
Menci
force-pushed
the
floway/inline-pick-into-serve
branch
from
87e1ce3 to
0c05f80
Compare
Menci
force-pushed
the
floway/canonicalize-responses-input
branch
from
1cd85a8 to
5037202
Compare
Menci
force-pushed
the
floway/inline-pick-into-serve
branch
from
0c05f80 to
5db19d3
Compare
Menci
force-pushed
the
floway/canonicalize-responses-input
branch
2 times, most recently
from
5b2a41a to
9539807
Compare
Menci
force-pushed
the
floway/inline-pick-into-serve
branch
2 times, most recently
from
046b62e to
c3ba39e
Compare
Menci
force-pushed
the
floway/canonicalize-responses-input
branch
from
9539807 to
e0ca637
Compare
Menci
force-pushed
the
floway/inline-pick-into-serve
branch
from
c3ba39e to
d6913b4
Compare
Menci
force-pushed
the
floway/canonicalize-responses-input
branch
2 times, most recently
from
b9e938e to
d8c7a48
Compare
Menci
force-pushed
the
floway/inline-pick-into-serve
branch
2 times, most recently
from
7d8f28f to
afd2d8d
Compare
Menci
force-pushed
the
floway/canonicalize-responses-input
branch
from
d8c7a48 to
e8f031e
Compare
Menci
force-pushed
the
floway/inline-pick-into-serve
branch
from
afd2d8d to
eb646be
Compare
Menci
force-pushed
the
floway/canonicalize-responses-input
branch
from
e8f031e to
fa7a3b6
Compare
Menci
force-pushed
the
floway/inline-pick-into-serve
branch
from
eb646be to
4b78b8d
Compare
Menci
force-pushed
the
floway/canonicalize-responses-input
branch
2 times, most recently
from
22ea872 to
feaa92c
Compare
Menci
force-pushed
the
floway/inline-pick-into-serve
branch
2 times, most recently
from
f8c9e6e to
9753aa9
Compare
Menci
force-pushed
the
floway/canonicalize-responses-input
branch
2 times, most recently
from
141056c to
c14d814
Compare
Menci
force-pushed
the
floway/inline-pick-into-serve
branch
2 times, most recently
from
3fd8b66 to
a00cf7c
Compare
Menci
force-pushed
the
floway/canonicalize-responses-input
branch
3 times, most recently
from
e95e773 to
dd6d30f
Compare
Menci
force-pushed
the
floway/inline-pick-into-serve
branch
from
a00cf7c to
4d16702
Compare
Menci
force-pushed
the
floway/canonicalize-responses-input
branch
from
dd6d30f to
b1b3830
Compare
Menci
force-pushed
the
floway/inline-pick-into-serve
branch
from
4d16702 to
69a13dd
Compare
Menci
force-pushed
the
floway/canonicalize-responses-input
branch
from
b1b3830 to
e5d21ad
Compare
Menci
force-pushed
the
floway/inline-pick-into-serve
branch
from
69a13dd to
977e529
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire `ResponsesPayload.input` is `string | InputItem[]`. The HTTP/WS entries normalize a bare-string `input` to a single synthetic user-role message immediately on parse, so every internal reader sees array-only input. Encoded in the type system via `CanonicalResponsesPayload = Omit<ResponsesPayload, 'input'> & { input: ResponsesInputItem[] }`.
Plumbed through every signature past the entry: `ResponsesServeGenerateArgs`, `ResponsesServeCompactArgs`, `ResponsesAttemptInvokeArgs`, `ResponsesInvocation` (the gateway-internal interceptor variant — provider-package `ResponsesInvocation` stays wire-shaped), `ResponsesServePlan.prepared`, `RewrittenResponsesPayload`, `expandPreviousResponseId`, `normalizeAssistantInputText`. Cross-protocol entries (messages/gemini translating to responses) re-canonicalize the translated payload via the exported `canonicalizeResponsesPayload` helper.
Removes every internal `typeof input === 'string'` branch: `expandPreviousResponseId`, `expandShimCompactionItems`, `simulateCompaction` (the shim's `originalInputItems` materialization), `containsCompactionTrigger`, `withInterleavedSystemDemotedToUser`, plus the matching obsolete tests.
Test plan