Preserve updated Q after cache eviction - #17
Open
Frankie-Xu wants to merge 1 commit into
Open
Frankie-Xu wants to merge 1 commit into
Frankie-Xu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MemoryService keeps both a fast
_q_cacheand a_mem_cacheof memory objects. After a successful Q update, FIFO eviction can remove an ID from_q_cache; the next retrieval then falls back to that memory object's stalemetadata.q_valueand silently loses the learned value.Synchronize the cached memory metadata after a successful non-None single or batch update. This keeps the existing in-process fallback consistent after Q-cache eviction without changing the Q-learning formula, FIFO policy, retrieval scoring, or cross-process behavior. Storage failures and unsuccessful updates do not mutate either cache.
Validation:
-0.5/0.5learned values fall back to0.0); failure and snapshot tests pass.git archiveexport.compileallandgit diff --checkpass.No live MemOS integration, cross-process consistency, concurrency redesign, or benchmark run is claimed. This is independent of PR #14's finite-value validation and PR #16's single-update Q-cache publication.