fix(bridge): detect hermes chat with global flags in bridge status check#1917
Open
lb1192176991-lab wants to merge 1 commit into
Open
fix(bridge): detect hermes chat with global flags in bridge status check#1917lb1192176991-lab wants to merge 1 commit into
lb1192176991-lab wants to merge 1 commit into
Conversation
Fixes MemTensor#1915 The `isHermesChatRunning()` function in bridge.cts uses pgrep with a fixed string pattern that fails when global flags are placed before the subcommand. Changed to a regex pattern that matches both `hermes chat` and `hermes --flags chat`.
lb1192176991-lab
force-pushed
the
fix/bridge-hermes-global-flags
branch
from
681d108 to
4587d66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1915
The
isHermesChatRunning()function inbridge.ctsusespgrep -f "hermes chat"which fails when global flags are placed before the subcommand (e.g.,hermes --skills memory-routing chat).Changed the pattern to a regex
"hermes\\s.*chat\\b"that matches:hermes chat(adjacent)hermes --flags chat(global flags before subcommand)hermes chat --flags(flags after subcommand, already worked)