Fix Oracle SID connection failing with DPY-4027#185
Open
PeterAdams-ecitsolutions wants to merge 1 commit intoMaxteabag:mainfrom
Open
Fix Oracle SID connection failing with DPY-4027#185PeterAdams-ecitsolutions wants to merge 1 commit intoMaxteabag:mainfrom
PeterAdams-ecitsolutions wants to merge 1 commit intoMaxteabag:mainfrom
Conversation
python-oracledb's thin mode rejects the legacy host:port:SID Easy-Connect form; it falls through to TNS alias resolution and fails with "no configuration directory specified" before any network activity. Use oracledb.makedsn(host, port, sid=...) instead, which emits a TNS descriptor that thin mode handles without any TNS_ADMIN setup. Update the SID unit tests (they previously asserted the broken DSN string as correct) and add a regression test that runs the adapter against the real driver to catch this class of parse-step failure. Closes Maxteabag#106
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #106.
The SID branch was building a
host:port:SIDDSN, which python-oracledb's thin mode doesn't accept — it treats it as a TNS alias, can't find one, and returnsDPY-4027: no configuration directory specified. Swapping tooracledb.makedsn(host, port, sid=...)emits a TNS descriptor that thin mode handles directly.Verified end-to-end against
gvenzl/oracle-freeon both the SID and service-name paths. Also updated the SID unit tests (they were asserting the broken format as correct) and added a regression test that runs against the real driver so this can't silently slip through mocks again.