Skip to content

fix windows not receiving env on boot #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattvb91 merged 5 commits into from
Apr 13, 2026
Merged

fix windows not receiving env on boot #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3d16bbc
first pass fix windows env bug by reproducing in ci
mattvb91 Apr 13, 2026
f282f4a
fix duplicate dir name issue
mattvb91 Apr 13, 2026
8b41cb1
lint
mattvb91 Apr 13, 2026
136f647
cross env dep
mattvb91 Apr 13, 2026
e20a552
update lock
mattvb91 Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/node.js.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:
jobs:
build:

runs-on: ubuntu-latest
runs-on: ${{ matrix.os }}

permissions:
# Required to checkout the code
Expand All @@ -18,6 +18,7 @@ jobs:
strategy:
matrix:
node-version: [24.x]
os: [ubuntu-latest, windows-latest]

steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -58,3 +59,8 @@ jobs:
npm run build
npm run lint
working-directory: ./packages/multiplayer-template

- name: Start dev servers and verify startup
timeout-minutes: 1
run: npx concurrently --kill-others --success first "npm run dev" "npx wait-on http://localhost:8050/api/game/health --timeout 20000"
working-directory: ./packages/multiplayer-template
2 changes: 1 addition & 1 deletion packages/multiplayer-template/client/src/Entities/Player.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import BasePlayer from '@template/server/Base/Player'
import { Vector3 } from 'three'
import IdleState from '../Player/IdleState'
import WalkingState from '../Player/WalkingState'
import PlayerLabel from '../ui/PlayerLabel'
import PlayerGraphicsComponent from './Player/PlayerGraphicsComponent'
import PlayerLabel from './Player/PlayerLabel'

export default class Character extends BasePlayer {
graphicalComponent: PlayerGraphicsComponent
Expand Down
0 ...yer-template/client/src/ui/PlayerLabel.ts → ...client/src/Entities/Player/PlayerLabel.ts
View file
Open in desktop
File renamed without changes.
36 changes: 31 additions & 5 deletions packages/multiplayer-template/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions packages/multiplayer-template/server/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"private": true,
"main": "src/index.ts",
"scripts": {
"start": "LOG_LEVEL=debug node ./dist/index.js",
"start": "cross-env LOG_LEVEL=debug node ./dist/index.js",
"dev": "tsup --watch --onSuccess \"npm run start\"",
"build": "tsup",
"typecheck": "tsc --noEmit"
Expand All @@ -19,6 +19,7 @@
},
"devDependencies": {
"@types/express": "^5.0.3",
"@types/node": "^24.0.0"
"@types/node": "^24.0.0",
"cross-env": "^10.1.0"
}
}
Loading