Merged
Conversation
rocky
commented
Apr 1, 2026
mathics_django/web/views.py
Outdated
| query_log.save() | ||
|
|
||
| evaluation = get_session_evaluation(request.session) | ||
| evaluation.iteration_count = 0 |
Member
Author
There was a problem hiding this comment.
@mmatera We didn't need to do this before. I am sure why it is needed now or whether this is the best way to do.
Your thoughts?
views.py: reset iteration count after each cell evaluation Makefile: "make runserver" should no set LOG_ON_CONSOLE, use make runserver-debug for that views.py: Detect $Aborted sooner inout.js: Show example where we set PrintPrecision to 6 like in a Notebook
rocky
commented
Apr 1, 2026
mathics_django/web/models.py
Outdated
| evaluation, expr, format | ||
| ) | ||
| autoload_files(definitions, ROOT_DIR, "autoload") | ||
| evaluation.iteration_count = 0 |
Member
Author
There was a problem hiding this comment.
@mmatera We didn't need to do this before. I am sure why it is needed now or whether this is the best way to do.
Your thoughts?
Contributor
There was a problem hiding this comment.
It shouldn't. MathicsSession set this to 0 on each evaluation...
Evaluation.evaluation should set this to 0, but it doesn't.
Member
Author
There was a problem hiding this comment.
Thanks! I'll put in a separate PR for this.
rocky
force-pushed
the
misc-tweaks
branch
4 times, most recently
from
4f757cd to
997ff6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
views.py: reset iteration count after each cell evaluation Makefile: "make runserver" should no set LOG_ON_CONSOLE, use make runserver-debug for that
views.py: Detect
$Abortedand$Failedsoonerinout.js: Show example where we set PrintPrecision to 6, like in a Notebook