<fix>[portforwarding]: skip detach when serviceUuids is empty#3869
Open
ZStack-Robot wants to merge 1 commit into5.5.16from
Open
<fix>[portforwarding]: skip detach when serviceUuids is empty#3869ZStack-Robot wants to merge 1 commit into5.5.16from
ZStack-Robot wants to merge 1 commit into5.5.16from
Conversation
PortForwardingConfigProxy.detachNetworkServiceFromNoHaVirtualRouter would generate 'AND vo.uuid IN ()' when called with an empty list, causing a MariaDB syntax error. Add an early return guard. Resolves: ZSTAC-84748 Change-Id: I15a86ffb92829af6952697a4f3cb1351cd5ed28c
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: http://open.zstack.ai:20001/code-reviews/zstack-cloud.yaml (via .coderabbit.yaml) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
概览在 变更
预估代码审查工作量🎯 1 (极简) | ⏱️ ~3 分钟 诗文
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PortForwardingConfigProxy.detachNetworkServiceFromNoHaVirtualRouter
would generate 'AND vo.uuid IN ()' when called with an empty list,
causing a MariaDB syntax error. Add an early return guard.
Resolves: ZSTAC-84748
Change-Id: I15a86ffb92829af6952697a4f3cb1351cd5ed28c
sync from gitlab !9744