handle an empty colormap element for substrate in svg #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a user recently had this issue where the
<colormap>element was empty but the substrate plotting was enabled. This throws a warning when the parsed colormap string is too short (empty or just a single character) and defaults to theYlOrRdcolormap that is the default.It's worth noting that defaulting to
YlOrRdalready occurs if the colormap string is not recognized. The issue with empty or 1-character colormaps is the check for a_rsuffix required checking two characters from the end. So, in short, this makes sure these pathological colormap strings also fall back to the same default.