Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ggevay
marked this pull request as ready for review
October 17, 2026 10:03
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I analyzed how SQL-806 slipped through AI reviews. It turns out that
guide-adapter.mdsays nothing about keeping the coordinator loop responsive. The specific gaps seem to have been:MissedTickBehavior::Skipdoes. (both in Claude and in my own head)This adds a short subsection to
guide-adapter.md's "Architecture & Key Concepts" that should take care of the above.(I'm also thinking to do a followup PR that would add some numbers: E.g., assume catalog sizes of 30k, 1000 clusters, how slow msgs are acceptable.)
(Also, we might want to create a Release Qualification test that builds up a very big catalog and does various things on it, e.g. a 0dt upgrade. The spec sheet is close to this, but doesn't do a 0dt upgrade.)
🤖 Generated with Claude Code