Repository navigation
Conversation
The timely logging demux kept, for every channel that carried a message, a dense array of per-peer counts in each direction, so its state grew with channels times workers squared across a replica. Most channels are pipeline channels on which a worker only talks to itself. Track a single local count per channel and widen to a per-peer array only once a channel carries a message to or from another worker. Retractions on dataflow shutdown cover the same non-zero updates as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The timely logging demux allocated a dense per-peer
MessageCountarray per channel and direction on every worker, so its state grew with channels times workers squared across a replica. Most channels are pipeline channels where a worker only talks to itself. Channels now keep a single local count and widen to the per-peer array on the first message to or from another worker. The logged message and batch counts, and their retractions on dataflow shutdown, are unchanged.On a local 32-worker replica with 60 indexed views over an auction load generator, 3882 of 4213 channels carrying messages were self-only. Sampled jemalloc heap held by the message count state fell from 81.5 MiB to 21 MiB.
Posted by Claude Code.
🤖 Generated with Claude Code