Repository navigation
storage-types: Remove test-only DataflowErrorRegion - #39881
Merged
antiguru merged 1 commit intoOct 15, 2026
Merged
Conversation
The `Columnation` impl for `DataflowError` and its `DataflowErrorRegion` only compiled under `test` or the `proptest` feature, and their only user was the region's own roundtrip test. Compute moves errors across dataflow edges as `DataflowErrorSer`, which has its own region. Remove the region, its test, and the `BoxStrStack` helper it used. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
frankmcsherry
approved these changes
Oct 15, 2026
frankmcsherry
left a comment
frankmcsherry
left a comment
Contributor
There was a problem hiding this comment.
Looks great; thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Columnationimpl forDataflowErrorand itsDataflowErrorRegiononly compile undertestor theproptestfeature, and their only user is the region's own roundtrip test. Compute moves errors across dataflow edges asDataflowErrorSer, which has its own region. This removes the region, itsdataflow_error_roundtriptest, and theBoxStrStackhelper it used.🤖 Generated with Claude Code