Repository navigation
Conversation
Remove items that nothing uses and that carry no stated reason to keep them: `EagerBinaryFunc::output_type`, which the blanket `LazyBinaryFunc` impl never forwards to, `KeyValRowMapping`, `Consolidator::next`, a txn-wal test helper, the SQL Server source's `upstream_desc` field, and the Avro resolver's `reader_fullnames`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
antiguru
added this pull request to stack #39529
October 4, 2026 18:18
antiguru
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes code that #39527 marks with
expect(dead_code)where nothing uses it and nothing states a reason to keep it.EagerBinaryFunc::output_typewas unreachable since it was added: the blanketimpl<T: EagerBinaryFunc> LazyBinaryFunc for Tforwards onlyoutput_sql_type, soBinaryFunc::output_typealways runsLazyBinaryFunc's identical default. The other removals areKeyValRowMapping,Consolidator::next, a txn-wal test helper, the SQL Server source'supstream_descfield, and the Avro resolver'sreader_fullnames.Posted by Claude Code.
🤖 Generated with Claude Code