Repository navigation
Conversation
leedqin
force-pushed
the
cluster-page-layout
branch
from
October 2, 2026 23:17
0d3a2b7 to
9748a34
Compare
leedqin
added this pull request to stack #39509
October 2, 2026 23:17
leedqin
force-pushed
the
cluster-page-layout
branch
from
October 5, 2026 15:19
9748a34 to
da596f5
Compare
leedqin
marked this pull request as ready for review
October 5, 2026 15:20
leedqin
force-pushed
the
cluster-page-layout
branch
2 times, most recently
from
October 7, 2026 02:24
86b3a41 to
3ebaa38
Compare
jdonelson
reviewed
Oct 7, 2026
| <Route path="sources" element={<Sources key={clusterName} />} /> | ||
| <Route path="sinks" element={<Sinks key={clusterName} />} /> | ||
| <Route | ||
| path="objects/:objectType" |
Contributor
There was a problem hiding this comment.
The new page's Objects tab links to bare objects, but the classic page only matches objects/:objectType. So a copied Objects tab link opens an empty body for someone who's opted out. Worth adding an objects route here that redirects too?
Contributor
Author
There was a problem hiding this comment.
The flag is on for everyone that is why I linked it here. Will make a note to remove Maintained Objects flag
Contributor
Author
There was a problem hiding this comment.
Good catch. The classic page now has an objects route that opens the first object tab, with a test.
leedqin
force-pushed
the
cluster-page-layout
branch
3 times, most recently
from
October 12, 2026 23:36
bb11a98 to
2e4d2c8
Compare
leedqin
force-pushed
the
cluster-page-layout
branch
4 times, most recently
from
October 15, 2026 17:50
7482674 to
0ef356b
Compare
First of a stack that redesigns the cluster details page. It sits behind the clusterDetailsRedesign UI preview (LaunchDarkly flag cluster-details-page-cns-173), which users opt into per browser from the page header. Without the opt-in the classic page is unchanged. The new page adds a title row with the cluster's size and replica count, and three tabs: Metrics (the existing overview for now), Objects (the existing materialized view, index, source and sink lists under one tab) and Replicas. Replicas is temporary until a configuration drawer manages replicas. Classic tab URLs redirect into the Objects tab, and objects/ URLs redirect to the classic tabs, so shared links work for both groups. The breadcrumbs move to their own module so both pages share them.
Self-managed deployments read flags from flexibleDeploymentFlags, where a flag that's absent counts as on, and they have no preview toggle. Without an entry, self-managed users would get the unfinished redesign with no way to opt out. Pin cluster-details-page-cns-173 to false there. Also switch the new page's relative imports to `~/` and spell the object type label "Materialized Views", matching the classic tabs.
leedqin
force-pushed
the
cluster-page-layout
branch
2 times, most recently
from
October 15, 2026 21:55
be135e0 to
f8a6ef1
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
First PR in a stack that redesigns the cluster details page. The redesign puts the object lists under one tab, moves cluster configuration into a drawer, and replaces the overview charts with a combined resource usage view. This PR lands only the page shell, so each later PR adds one piece behind the same flag.
Description
clusterDetailsRedesign, offered by the LaunchDarkly flagcluster-details-page-cns-173. Users who are offered it opt in per browser from the pill in the breadcrumb bar ("Show the new cluster details page" / "Show classic cluster details page"). Self-managed keeps the classic page: it has no preview toggle and treats unlisted flags as on, sodisabledFlexibleDeploymentFlagspinscluster-details-page-cns-173off.ClusterOverviewuntil the resource usage PR replaces it.objects/:objectType./indexesand the rest) redirect into the Objects tab, andobjects/<type>URLs redirect to the matching classic tab, or to Overview for an unknown type. A bareobjectslink opens the first classic object tab.ClusterDetailBreadcrumbsmoves to its own module so both pages share it. Its only change is hosting the preview pill.Next in the stack: the resource usage data (#39507) and charts (#39508), then memory by object, worker skew, and the configuration drawer.
The
cluster-details-page-cns-173flag is on in LaunchDarkly's Staging environment, which PR previews read. Production needs it too before the preview can be offered there.Verification
ClusterDetail.test.tsxadds tests for:useUiPreview.test.tsxadds a test that self-managed keeps the redesign off.🤖 Generated with Claude Code