Skip to content

Rename pretty-only explain functions to indicate they're not user-facing.#35211

Merged
ublubu merged 1 commit intoMaterializeInc:mainfrom
ublubu:debug_explain
Feb 26, 2026
Merged

Rename pretty-only explain functions to indicate they're not user-facing.#35211
ublubu merged 1 commit intoMaterializeInc:mainfrom
ublubu:debug_explain

Conversation

@ublubu
Copy link
Contributor

@ublubu ublubu commented Feb 25, 2026

Left over from #34873

#34873 (comment)

how about we rename these explain functions that are called only from pretty to something like debug_explain

@ublubu ublubu requested a review from a team as a code owner February 25, 2026 15:51
@ublubu ublubu requested a review from ggevay February 25, 2026 15:51
@github-actions
Copy link

Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone.

PR title guidelines

  • Use imperative mood: "Fix X" not "Fixed X" or "Fixes X"
  • Be specific: "Fix panic in catalog sync when controller restarts" not "Fix bug" or "Update catalog code"
  • Prefix with area if helpful: compute: , storage: , adapter: , sql:

Pre-merge checklist

  • The PR title is descriptive and will make sense in the git log.
  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).

@ublubu ublubu enabled auto-merge (squash) February 25, 2026 16:31
Copy link
Contributor

@ggevay ggevay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ublubu ublubu merged commit 65fb19d into MaterializeInc:main Feb 26, 2026
136 checks passed
@ublubu ublubu deleted the debug_explain branch February 26, 2026 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants