Support setting cpu_request in cluster replica sizes#35196
Draft
alex-hunt-materialize wants to merge 1 commit intoMaterializeInc:mainfrom
Draft
Support setting cpu_request in cluster replica sizes#35196alex-hunt-materialize wants to merge 1 commit intoMaterializeInc:mainfrom
alex-hunt-materialize wants to merge 1 commit intoMaterializeInc:mainfrom
Conversation
|
Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone. PR title guidelines
Pre-merge checklist
|
84e2a51 to
d5268af
Compare
d5268af to
7b796ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports setting cpu_request independently of cpu_limit in cluster replica sizes.
Motivation
Resolves https://github.com/MaterializeInc/database-issues/issues/10100
More context:
https://materializeinc.slack.com/archives/C07PN7KSB0T/p1770215227882419
https://materializeinc.slack.com/archives/C0854GU86HL/p1771932457688129
Description
Also updates a massive number of our crates to not pull in default features for other crates. This is needed to avoid pulling in workspace hack when default-features=false, to avoid pulling in workspace hack in the cloud repo.
It's easier to review the two commits separately.
Verification
Orchestratord nightly tests should exercise the main code change, but I'm running all of them due to the default features changes.