Skip to content

ci-builder: Fix --no-secrets on Linux and add .npm caching#35195

Open
def- wants to merge 1 commit intoMaterializeInc:mainfrom
def-:pr-claude-builder-fix-linux
Open

ci-builder: Fix --no-secrets on Linux and add .npm caching#35195
def- wants to merge 1 commit intoMaterializeInc:mainfrom
def-:pr-claude-builder-fix-linux

Conversation

@def-
Copy link
Contributor

@def- def- commented Feb 24, 2026

I was primarily testing bin/claude-builder on macOS, so didn't notice this mistake.

@def- def- requested a review from bosconi February 24, 2026 14:18
@github-actions
Copy link

Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone.

PR title guidelines

  • Use imperative mood: "Fix X" not "Fixed X" or "Fixes X"
  • Be specific: "Fix panic in catalog sync when controller restarts" not "Fix bug" or "Update catalog code"
  • Prefix with area if helpful: compute: , storage: , adapter: , sql:

Pre-merge checklist

  • The PR title is descriptive and will make sense in the git log.
  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).

@def- def- marked this pull request as draft February 24, 2026 14:25
@def- def- marked this pull request as ready for review February 24, 2026 14:29
@def- def- force-pushed the pr-claude-builder-fix-linux branch from bf98239 to c90d85c Compare February 24, 2026 14:29
@def- def- force-pushed the pr-claude-builder-fix-linux branch from c90d85c to 10b962a Compare February 24, 2026 14:37
@def- def- changed the title ci-builder: Fix --no-secrets on Linux ci-builder: Fix --no-secrets on Linux and add .npm caching Feb 24, 2026
@def- def- enabled auto-merge (squash) February 24, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant