Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file.
74 changes: 0 additions & 74 deletions .claude/skills/mz-pr-review/SKILL.md

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ Session Task Coordinator
| |
|-- acquire OCC semaphore |
| |
|-- CreateReadThenWriteSubscribe ----> |
|-- CreateInternalSubscribe ---------> |
| <------------ subscribe channel -----|
| |
| +-- OCC Loop ------------------+ |
Expand All @@ -141,7 +141,7 @@ Session Task Coordinator
| | if Success: break | |
| +------------------------------+ |
| |
|-- DropReadThenWriteSubscribe ------> |
|-- DropInternalSubscribe -----------> |
| |
```

Expand Down Expand Up @@ -193,7 +193,7 @@ subscribe.
The subscribes created for read-then-write are internal: they do not appear in
`mz_subscriptions` or other introspection tables, and they don't increment the
active subscribes metric. They are created and dropped via dedicated `Command`
variants (`CreateReadThenWriteSubscribe`, `DropReadThenWriteSubscribe`).
variants (`CreateInternalSubscribe`, `DropInternalSubscribe`).

## Correctness

Expand Down
5 changes: 5 additions & 0 deletions misc/python/materialize/mzcompose/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,11 @@ def get_variable_system_parameters(
"true",
["true", "false"],
),
VariableSystemParameter(
"enable_adapter_frontend_occ_read_then_write",
"true",
["true", "false"],
),
VariableSystemParameter(
"enable_cast_elimination",
"false",
Expand Down
3 changes: 3 additions & 0 deletions misc/python/materialize/parallel_workload/action.py
Original file line number Diff line number Diff line change
Expand Up @@ -1520,6 +1520,9 @@ def __init__(
"false",
]
self.flags_with_values["enable_cast_elimination"] = BOOLEAN_FLAG_VALUES
self.flags_with_values["enable_adapter_frontend_occ_read_then_write"] = (
BOOLEAN_FLAG_VALUES
)

# If you are adding a new config flag in Materialize, consider using it
# here instead of just marking it as uninteresting to silence the
Expand Down
8 changes: 8 additions & 0 deletions src/adapter-types/src/dyncfgs.rs
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,13 @@ pub const ENABLE_S3_TABLES_REGION_CHECK: Config<bool> = Config::new(
"Whether to enforce that S3 Tables connections are in the same region as the environment.",
);

pub const FRONTEND_READ_THEN_WRITE: Config<bool> = Config::new(
"enable_adapter_frontend_occ_read_then_write",
// WIP: true for testing in ci, Should be false before merging.
true,
"Use frontend sequencing for DELETE/UPDATE operations.",
);

/// Adds the full set of all adapter `Config`s.
pub fn all_dyncfgs(configs: ConfigSet) -> ConfigSet {
configs
Expand All @@ -178,4 +185,5 @@ pub fn all_dyncfgs(configs: ConfigSet) -> ConfigSet {
.add(&CONSTRAINT_BASED_TIMESTAMP_SELECTION)
.add(&PERSIST_FAST_PATH_ORDER)
.add(&ENABLE_S3_TABLES_REGION_CHECK)
.add(&FRONTEND_READ_THEN_WRITE)
}
3 changes: 3 additions & 0 deletions src/adapter/src/active_compute_sink.rs
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,9 @@ pub struct ActiveSubscribe {
pub start_time: EpochMillis,
/// How to present the subscribe's output.
pub output: SubscribeOutput,
/// If true, this is an internal subscribe that should not appear in
/// introspection tables like mz_subscriptions.
pub internal: bool,
}

impl ActiveSubscribe {
Expand Down
Loading