Add persist-backed compute introspection sources#35172
Draft
antiguru wants to merge 1 commit intoMaterializeInc:mainfrom
Draft
Add persist-backed compute introspection sources#35172antiguru wants to merge 1 commit intoMaterializeInc:mainfrom
antiguru wants to merge 1 commit intoMaterializeInc:mainfrom
Conversation
|
Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone. PR title guidelines
Pre-merge checklist
|
18535d5 to
c8bd29f
Compare
Adds per-replica introspection sources backed by persist shards,
enabling queryable introspection data that survives replica restarts.
Each replica gets a dedicated schema (mz_introspection_{cluster}_{replica})
containing sources and views derived from compute log variants. Sources
live in a separate durable collection while views use the regular items
collection. Cleanup is handled via the dependency system through
cluster_replica_dependents → schema_dependents.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
c8bd29f to
41d4407
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reintroduces direct persist writes from compute replicas for introspection data, bypassing environmentd for the data path.
The coordinator's role is limited to shard allocation and lifecycle management.
CREATE CLUSTER ... (PERSIST INTROSPECTION = true)opt-in +enable_persist_introspectiondyncfg kill switchLoggingConfig.sink_logscarries shard metadata to replicasGlobalId::PersistedIntrospectionSourceencoding per replica+variant🤖 Generated with Claude Code