Repository navigation
fix(DialogHost): allow Show() call from window constructor - #4127
Merged
Merged
Conversation
Keboo
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3804
The
DialogHostonly registered itself onLoaded, so callingDialogHost.Show(...)from a window constructor threw "No loaded DialogHost instances" or the dialog simply is not shown.Register()methodOnInitialized()to register as soon as XAML initialization completeLoadedstill registers too, so the host works again after being unloaded and reloaded (the DialogHost | Dialog no longer visible if disconnected-then-reconnect to VM running application #3069 behavior is unchanged)