Skip to content

Position DatePicker and TimePicker popups below input fields #4052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Keboo merged 2 commits into from
May 15, 2026
Merged

Position DatePicker and TimePicker popups below input fields #4052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b84c44e
Position date and time picker popups below fields
Keboo May 15, 2026
ba9c0cc
Remove flaky popup placement UI tests pending better implementation
Keboo May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions src/MaterialDesignThemes.Wpf/CustomPopupPlacementCallbackHelper.cs
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions src/MaterialDesignThemes.Wpf/Themes/MaterialDesignTheme.DatePicker.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,7 @@
Template="{StaticResource CalendarButtonTemplate}" />
<Popup x:Name="PART_Popup"
AllowsTransparency="True"
CustomPopupPlacementCallback="{x:Static wpf:CustomPopupPlacementCallbackHelper.LargePopupCallback}"
Placement="Custom"
Placement="Bottom"
PlacementTarget="{Binding ElementName=PART_TextBox}"
PopupAnimation="Fade"
StaysOpen="False" />
Expand Down
3 changes: 1 addition & 2 deletions src/MaterialDesignThemes.Wpf/Themes/MaterialDesignTheme.TimePicker.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,7 @@
Template="{StaticResource ClockButtonTemplate}" />
<Popup x:Name="PART_Popup"
AllowsTransparency="True"
CustomPopupPlacementCallback="{x:Static wpf:CustomPopupPlacementCallbackHelper.LargePopupCallback}"
Placement="Custom"
Placement="Bottom"
PlacementTarget="{Binding ElementName=PART_TextBox}"
PopupAnimation="Fade"
StaysOpen="False" />
Expand Down
1 change: 1 addition & 0 deletions tests/MaterialDesignThemes.UITests/WPF/DatePickers/DatePickerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,7 @@ public async Task DatePicker_ShouldApplyIsMouseOverTriggers_WhenHoveringCalendar

recorder.Success();
}

}

public class FutureDateValidationRule : ValidationRule
Expand Down
Loading