Fix nullability errors in UI tests#4051
Merged
Merged
Conversation
Use non-null values returned from IsNotNull() assertions in UI tests to remove nullable Value dereferences while preserving test behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The pipeline run against
mastersurfacedCS8629nullability errors in UI tests where nullableColor?values were dereferenced via.Value.What changed
This updates the affected UI tests to use the non-null value returned by
await Assert.That(...).IsNotNull()before contrast checks.DialogHostTests: use asserted non-null foreground values for both text blocks.TabControlTests: use asserted non-null foreground/background values in contrast and underline assertions.ColorAdjustTests: use asserted non-null foreground values in both contrast calculations.Notes
This keeps test behavior the same while satisfying nullable analysis and keeping assertion style consistent across the touched tests.