Skip to content

feat(yasqe): add showShareButton and showFullscreenButton options - #252

Merged
MathiasVDA merged 1 commit into
mainfrom
claude/project-thread-l97jxx
Oct 29, 2026
Merged

MathiasVDA merged 1 commit into
mainfrom
claude/project-thread-l97jxx

Conversation

@MathiasVDA

Copy link
Copy Markdown
Collaborator

Requested by Mathias · project thread

Closes #251.

The developer guide documented a Yasqe showShareButton option that was never implemented, and the editor's fullscreen button could not be hidden at all.

Changes

  • New Yasqe options showShareButton and showFullscreenButton, both default true (no behaviour change for existing setups).
  • When off, the button is not drawn, its item in the mobile (hamburger) menu is left out, and the Ctrl+K search drops the matching command (it already only lists tools that exist).
  • The mobile menu's Share item now depends on the Share button actually existing, so createShareableLink: null keeps working as before.
  • F11 still toggles the fullscreen editor when the button is hidden.
  • Works in Yasgui through yasqe: { showShareButton: false, showFullscreenButton: false }.
  • Developer guide: fixed the wrong default (false → true) and documented showFullscreenButton.
  • Changeset: minor for @matdata/yasqe.

Tests

  • New puppeteer tests under "Yasqe › Editor buttons" (default shows both, options hide both incl. menu items): passing.
  • Checked by hand in the Yasgui build page that both buttons disappear from the editor toolbar with the options set.

Generated by Claude Code

The developer guide listed a showShareButton option that did not exist,
and the fullscreen button could not be hidden at all. Both options
default to true and also hide the matching mobile menu items.

Closes #251
@MathiasVDA MathiasVDA self-assigned this Oct 29, 2026
@MathiasVDA
MathiasVDA merged commit 342e5f0 into main Oct 29, 2026
2 checks passed
@MathiasVDA
MathiasVDA deleted the claude/project-thread-l97jxx branch October 29, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hiding button options are missing

1 participant