Repository navigation
feat(yasqe): add showShareButton and showFullscreenButton options - #252
Merged
Merged
Conversation
The developer guide listed a showShareButton option that did not exist, and the fullscreen button could not be hidden at all. Both options default to true and also hide the matching mobile menu items. Closes #251
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Mathias · project thread
Closes #251.
The developer guide documented a Yasqe
showShareButtonoption that was never implemented, and the editor's fullscreen button could not be hidden at all.Changes
showShareButtonandshowFullscreenButton, both defaulttrue(no behaviour change for existing setups).createShareableLink: nullkeeps working as before.yasqe: { showShareButton: false, showFullscreenButton: false }.false→true) and documentedshowFullscreenButton.@matdata/yasqe.Tests
Generated by Claude Code