refactor: harden application composition - #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
add_book.Why
The old container accepted an arbitrary configuration dictionary. Missing values failed later with unclear errors, while some clients could be created with invalid values.
Resource cleanup was repeated across entry points, so a partial startup failure could leave clients open. Every process also received the same large database pool, which could exceed PostgreSQL capacity when replicas were added.
The API exposed a SendGrid circuit breaker that belonged to another process, so that health result did not describe real notification delivery. Command wiring was also difficult to read because both the business operation and its cache decorator were called handlers.
Impact
The public HTTP API is unchanged.
Database pool environment variables are now role-specific, for example
DATABASE_API_POOL_SIZEandDATABASE_WORKFLOW_POOL_SIZE. The config seeder validates the new format and removes obsolete etcd keys.Configuration is an immutable startup snapshot. Changing etcd configuration requires a controlled process restart.
Checks completed
GitHub Actions will run the full suite against a fresh migrated PostgreSQL database before merge.