Eliminate test-run warnings - #41
Merged
Merged
Conversation
Of the 101 deprecation warnings in CI, 100 came from the unmaintained etcd3 library's generated protobuf code (the reason for the protobuf<4 pin) and protobuf itself — not actionable here, now filtered per-module in pytest config with the reasoning documented. The remaining five were ours: datetime.utcnow() (deprecated in 3.12) in the JSON logger and the health endpoints, replaced with timezone-aware datetime.now(timezone.utc) preserving the existing timestamp formats. Test runs now emit zero warnings, so a new deprecation in our own code is a visible signal instead of line 102 of noise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI's 101 warnings, triaged:
etcd3's generated protobuf code + protobuf internals — third-party, unmaintained upstream (the reason for ourprotobuf<4pin). Not actionable here: filtered per-module in pytest config, with the reasoning documented next to the filter.datetime.utcnow()injson_logger.pyandhealth_routes.py— replaced with timezone-awaredatetime.now(timezone.utc), output formats preserved (trailingZin log timestamps kept).Result: 157 passed, zero warnings. The point isn't cosmetic — with a silent baseline, the next deprecation in our code is a visible signal instead of drowning at line 102.