Fix CI: register src package for installation - #40
Merged
Conversation
pip install -e . installed nothing importable: setuptools auto-discovery does not pick up the src package without configuration, so CI's bare pytest (which, unlike python -m pytest, does not put the cwd on sys.path) failed with ModuleNotFoundError. Declare the package explicitly; verified by running the suite from outside the repo root against the installed package only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The first CI run on main failed:
pip install -e .was installing nothing importable because setuptools auto-discovery doesn't register thesrcpackage without explicit configuration. Locally this was masked bypython -m pytestputting the repo root onsys.path; CI's barepytesthas no such crutch.Fix:
[tool.setuptools.packages.find] include = ["src*"].Verified by running the full non-e2e suite from outside the repo root against the installed package only — 157 passed.