Skip to content

feat(ci): CodeQL advanced setup that skips plots/** - #11200

Merged
MarkusNeusinger merged 5 commits into
mainfrom
feat/codeql-skip-plots
Sep 2, 2026
Merged

feat(ci): CodeQL advanced setup that skips plots/**#11200
MarkusNeusinger merged 5 commits into
mainfrom
feat/codeql-skip-plots

Conversation

@MarkusNeusinger

Copy link
Copy Markdown
Owner

Summary

  • CodeQL runs here as GitHub's default setup, which cannot exclude paths: every push to an implementation/* branch and every impl-* PR triggered a full five-language scan. During the 4-slot backfill of 2026-09-02 up to 23 CodeQL runs waited in the runner queue at once, ahead of the pipeline's own jobs.
  • .github/workflows/codeql.yml is the advanced-setup equivalent: same languages (actions, javascript-typescript, python), weekly cron, push/pull_request on main with paths-ignore: plots/**, and the same exclusion inside the analysis config so a docs-only push does not scan thousands of generated plot files. Actions are SHA-pinned (codeql-action v4.37.9).
  • Follow-up in repository settings (not a code change): default setup must be disabled (Code security → Code scanning) after this merges; GitHub rejects advanced-setup uploads while default setup is on. I will do that right after the merge and confirm the first workflow run.

Plan

N/A

Test plan

  • The PR itself triggers the new workflow (it changes files outside plots/**); the three Analyze (...) jobs may report an upload conflict until default setup is switched off — expected.
  • After the settings change: a push to main outside plots/** runs all three analyses green; the next impl-* PR starts no CodeQL run.

🤖 Generated with Claude Code

https://claude.ai/code/session_01SrKzcwZBnref1sWYtdXynu

The default setup scanned five languages on every push to an
implementation/* branch and every impl-* pull request; during the 4-slot
backfill of 2026-09-02 up to 23 CodeQL runs waited in the runner queue at
once, ahead of the pipeline's own jobs. The workflow keeps the same
languages and weekly schedule but ignores plots/** both as a trigger and
inside the analysis. Default setup has to be switched off in the
repository settings for the workflow's uploads to be accepted.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SrKzcwZBnref1sWYtdXynu
Copilot AI lite review requested due to automatic review settings September 2, 2026 16:19
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SrKzcwZBnref1sWYtdXynu

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The changelog update introduces a duplicate ### Changed section under [Unreleased], which should be consolidated to keep the changelog structure consistent.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Switches CodeQL from GitHub’s default setup to an advanced CodeQL workflow so the repository can exclude generated plot implementations under plots/**, reducing runner queue pressure caused by impl-* pipeline activity.

Changes:

  • Add an advanced CodeQL workflow (.github/workflows/codeql.yml) that excludes plots/** in both triggers and analysis config.
  • Document the new workflow in docs/workflows/overview.md.
  • Add a changelog entry describing the CodeQL setup change.
File summaries
File Description
docs/workflows/overview.md Adds codeql.yml to the workflow overview table with its purpose and exclusions.
CHANGELOG.md Records the CodeQL advanced-setup switch under [Unreleased].
.github/workflows/codeql.yml Introduces the advanced CodeQL workflow with plots/** excluded from triggers and analysis.
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread CHANGELOG.md Outdated
Copilot AI review requested due to automatic review settings September 2, 2026 16:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The workflow, docs, and changelog changes are consistent with the PR’s stated goal and correctly exclude plots/** at both trigger and analysis levels.

Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

Copilot AI review requested due to automatic review settings September 2, 2026 16:26
MarkusNeusinger and others added 2 commits September 2, 2026 18:27
Review feedback: [Unreleased] already had a Changed heading; a second one
broke the Keep-a-Changelog structure.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SrKzcwZBnref1sWYtdXynu

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The workflow, documentation, and changelog updates are consistent with the PR description and correctly exclude plots/** from both triggers and analysis.

Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

Copilot AI review requested due to automatic review settings September 2, 2026 16:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The workflow and documentation changes are consistent with existing repo workflow conventions (SHA pinning, concurrency patterns) and correctly exclude plots/** at both trigger and analysis levels.

Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

@MarkusNeusinger
MarkusNeusinger merged commit 87c84f5 into main Sep 2, 2026
8 of 11 checks passed
@MarkusNeusinger
MarkusNeusinger deleted the feat/codeql-skip-plots branch September 2, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants