ISSUE-690: Create AI model whitelist configuration#693
ISSUE-690: Create AI model whitelist configuration#693
Conversation
Naragod
force-pushed
the
ISSUE-690_enable_ai_model_whitelist_configuration
branch
2 times, most recently
from
94bd5bf to
96d131b
Compare
donny-wong
left a comment
donny-wong
left a comment
There was a problem hiding this comment.
Hi @Naragod , I think you misunderstood the requirements for this Issue. We specifically would like to whitelist what is allowed to put in the remote_url argument for the RemoteModel class.
Naragod
force-pushed
the
ISSUE-690_enable_ai_model_whitelist_configuration
branch
from
1c5c352 to
a908525
Compare
Hi @donny-wong I have made some changes. Please take a look. |
Will mention here
Will document here what we spoke about: We will not use a whitelist file but instead put the list of allowed endpoint urls in the settings.yml file. |
Naragod
force-pushed
the
ISSUE-690_enable_ai_model_whitelist_configuration
branch
from
34b2621 to
831c2b4
Compare
Naragod
force-pushed
the
ISSUE-690_enable_ai_model_whitelist_configuration
branch
from
0cbcffe to
362ccd9
Compare
Naragod
force-pushed
the
ISSUE-690_enable_ai_model_whitelist_configuration
branch
from
05f7be1 to
362ccd9
Compare
for more information, see https://pre-commit.ci
donny-wong
left a comment
donny-wong
left a comment
There was a problem hiding this comment.
Good job @Naragod! I left a few comments.
| self.tags = [] | ||
|
|
||
| # Default remote URL used by RemoteModel when none is specified | ||
| DEFAULT_REMOTE_URL = "https://polymouth.teach.cs.toronto.edu:443/chat" |
There was a problem hiding this comment.
Please make values like this as a setting configuration.
| }, | ||
| "submission": { "type": "string" }, | ||
| "model": { "type": "string" }, | ||
| "remote_url": { "type": "string" }, |
There was a problem hiding this comment.
This is not needed for this PR. Settings_schema is when we want to modify the MarkUs UI automated tests settings.
2 participants
Description:
We wish to dynamically whitelist AI models available for use. To prevent the potential exposure of sensitive data when autograding/autotesting assignments, we wish to restrict usage to remote models.
Implementation
Allow users when creating an assignment the ability to submit a whitelist of available models. When the autotest is ran, any models used missing from this list will fail to execute.
Note
This PR is dependent on USTORY-549.