Update CSP for ExamTemplatesController and GroupsController - #8109
Open
mrafie1 wants to merge 3 commits into
Open
Update CSP for ExamTemplatesController and GroupsController#8109mrafie1 wants to merge 3 commits into
mrafie1 wants to merge 3 commits into
Conversation
Collaborator
Coverage Report for CI Build 31046530609Coverage remained the same at 90.589%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
:blobCSP exception for images inapp/controllers/exam_templates_controller.rbandapp/controllers/groups_controller.rbReasoning:
Both controllers take in files (
data.fileLinkorpath) as URLs_assign_errors.js.erbwhich displays PDFs forexam_templates_controllerassigns_scans.html.erbwhich displays PDFs forgroups_controllerPDFViewer itself does not convert PDFs into blobs: it keeps the URL.
pdf_viewer.jsxfile and its functionloadPDFFileAdditionally, when viewing PDF files, they are not converted into "blob" images; they keep their original file link.
Since blob is not being used by PDFViewer and the image is kept as its original link by the
exam_templates_controllerand `groups_controller, it is safe to remove it from the CSP.Screenshots of your changes (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)