Conversation
There was a problem hiding this comment.
Pull request overview
Updates the generated extension gallery’s sorting so entries appear in a “Discover”-style order (featured first, then newest/updated, then natural name ordering), and adds test coverage for the ordering behavior.
Changes:
- Introduce a shared
compareEntriescomparator to sort gallery entries by featured status, relevant date, and then name/id. - Use
Intl.Collatorwith numeric comparison for human-friendly name sorting (e.g., “Theme 2” before “Theme 10”). - Add a new unit test asserting the gallery ordering.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/gallery.test.mjs | Adds a regression test covering the expected “Discover” ordering in the rendered HTML. |
| scripts/lib/gallery.mjs | Implements the new entry ordering strategy via a reusable comparator and updates gallery sorting to use it. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.