Skip to content

MDEV-40218 lock_rec_unlock_unmodified<CELL>() can release a stale per… #5307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iMineLink merged 1 commit into from
Jun 30, 2026
+10 −3
Merged

MDEV-40218 lock_rec_unlock_unmodified<CELL>() can release a stale per… #5307

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions storage/innobase/lock/lock0lock.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4534,15 +4534,17 @@ static void lock_rec_unlock(hash_cell_t &cell, lock_t *lock, ulint heap_no)

/** Release locks to unmodified records on a clustered index page.
@param block the block containing locked records
@param cell lock_sys.rec_hash cell of lock
@param cell lock_sys.rec_hash cell of lock; updated in place to the
currently held cell, which a concurrent
lock_sys_t::hash_table::resize() may have moved
Comment thread
iMineLink marked this conversation as resolved.
@param lock record lock
@param offsets storage for rec_get_offsets()
@tparam latch_type how the caller of the function latched lock_sys,
GLOBAL or CELL
@return true if the cell was latched successfully or if latch_type is GLOBAL,
false otherwise */
template <lock_sys_latch_type latch_type>
bool lock_rec_unlock_unmodified(buf_block_t *block, hash_cell_t *cell,
bool lock_rec_unlock_unmodified(buf_block_t *block, hash_cell_t *&cell,
lock_t *lock, rec_offs *offsets)
{
DEBUG_SYNC_C("lock_rec_unlock_unmodified_start");
Expand Down Expand Up @@ -4716,7 +4718,12 @@ static bool lock_release_on_prepare_try(trx_t *trx, bool unlock_unmodified)
offsets))
all_released= false;
else
latch->release();
/* lock_rec_unlock_unmodified() may have released and
re-acquired lock_sys, during which a concurrent
lock_sys_t::hash_table::resize() could move the cell. It
reports the currently held cell in cell, so release that
cell's latch rather than the now possibly stale latch. */
lock_sys_t::hash_table::latch(cell)->release();
}
else
all_released= false;
Expand Down