Skip to content

MDEV-36896 - Assertion `marked_for_read()' failed in virtual String *Field_varstring::val_str(String *, String *) #5158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pranavktiwari wants to merge 3 commits into
base: 10.11
Choose a base branch
from
+70 −4
Open

MDEV-36896 - Assertion `marked_for_read()' failed in virtual String *Field_varstring::val_str(String *, String *) #5158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4428320
MDEV-36896 : Assertion 'marked_for_read()' failed in virtual String *…
pranavktiwari Jun 1, 2026
747242c
Added logic to update the all fileds in map.
pranavktiwari Jun 29, 2026
b52f86e
Added a new bit map
pranavktiwari Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions mysql-test/suite/vcol/r/vcol_keys_innodb.result
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,3 +303,31 @@ IF(@@innodb_sort_buffer_size < count(*)*200, 'GOOD', 'WRONG SIZE')
GOOD
alter table t1 drop column va;
drop table t1;
#
# MDEV-36896 Assertion `marked_for_read()' failed in virtual String *Field_varstring::val_str(String *, String *)
#
SET @old_isolation_level= @@session.tx_isolation;
SET @@session.tx_isolation= 'READ-UNCOMMITTED';
CREATE TABLE t (a VARCHAR(10),b INT,c CHAR(10) GENERATED ALWAYS AS (a) VIRTUAL,KEY(b,c)) ENGINE=InnoDB;
INSERT INTO t (a) VALUES ('A');
SELECT * FROM t WHERE b IS NULL ORDER BY a;
a b c
A NULL A
DROP TABLE t;
CREATE TABLE t (
a VARCHAR(10),
b INT,
c CHAR(10) GENERATED ALWAYS AS (a) VIRTUAL,
d INT GENERATED ALWAYS AS (IF(a = c, 1, 0)) VIRTUAL,
KEY(b, c)
) ENGINE=InnoDB;
INSERT INTO t (a) VALUES ('A');
INSERT INTO t (a, b) VALUES ('B', 1);
SELECT * FROM t WHERE b IS NULL ORDER BY a;
a b c d
A NULL A 1
DROP TABLE t;
SET @@session.tx_isolation= @old_isolation_level;
#
# End of 10.11 tests
#
33 changes: 33 additions & 0 deletions mysql-test/suite/vcol/t/vcol_keys_innodb.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,3 +135,36 @@ insert t1 (id,a,c) select seq,seq,seq from seq_1_to_330;
select IF(@@innodb_sort_buffer_size < count(*)*200, 'GOOD', 'WRONG SIZE') from t1;
alter table t1 drop column va;
drop table t1;


--echo #
--echo # MDEV-36896 Assertion `marked_for_read()' failed in virtual String *Field_varstring::val_str(String *, String *)
--echo #

SET @old_isolation_level= @@session.tx_isolation;

SET @@session.tx_isolation= 'READ-UNCOMMITTED';
CREATE TABLE t (a VARCHAR(10),b INT,c CHAR(10) GENERATED ALWAYS AS (a) VIRTUAL,KEY(b,c)) ENGINE=InnoDB;
INSERT INTO t (a) VALUES ('A');
SELECT * FROM t WHERE b IS NULL ORDER BY a;

DROP TABLE t;

CREATE TABLE t (
a VARCHAR(10),
b INT,
c CHAR(10) GENERATED ALWAYS AS (a) VIRTUAL,
d INT GENERATED ALWAYS AS (IF(a = c, 1, 0)) VIRTUAL,
KEY(b, c)
) ENGINE=InnoDB;

INSERT INTO t (a) VALUES ('A');
INSERT INTO t (a, b) VALUES ('B', 1);
SELECT * FROM t WHERE b IS NULL ORDER BY a;
DROP TABLE t;

SET @@session.tx_isolation= @old_isolation_level;

--echo #
--echo # End of 10.11 tests
--echo #
5 changes: 3 additions & 2 deletions sql/item.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -980,12 +980,13 @@ bool Item_field::check_field_expression_processor(void *arg)
bool Item_field::update_vcol_processor(void *arg)
{
MY_BITMAP *map= (MY_BITMAP *) arg;
if (field->vcol_info &&
!bitmap_fast_test_and_set(map, field->field_index))

if (!bitmap_fast_test_and_set(map, field->field_index) && field->vcol_info)
{
field->vcol_info->expr->walk(&Item::update_vcol_processor, 0, arg);
field->vcol_info->expr->save_in_field(field, 0);
}

return 0;
}

Expand Down
8 changes: 6 additions & 2 deletions sql/table.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9187,8 +9187,11 @@ int TABLE::update_virtual_field(Field *vf, bool ignore_warnings)
TABLE::update_virtual_fields(handler *, enum_vcol_update_mode).
*/
in_use->set_n_backup_active_arena(expr_arena, &backup_arena);
bitmap_clear_all(&tmp_set);
vf->vcol_info->expr->walk(&Item::update_vcol_processor, 0, &tmp_set);

MY_BITMAP local_set;
my_bitmap_init(&local_set, NULL, s->fields);
bitmap_set_bit(&local_set, vf->field_index);
Comment on lines +9191 to +9193
vf->vcol_info->expr->walk(&Item::update_vcol_processor, 0, &local_set);
DBUG_FIX_WRITE_SET(vf);
vf->vcol_info->expr->save_in_field(vf, 0);
DBUG_RESTORE_WRITE_SET(vf);
Expand All @@ -9201,6 +9204,7 @@ int TABLE::update_virtual_field(Field *vf, bool ignore_warnings)
// This is an internal calculation, we expect it to always succeed
DBUG_ASSERT(count_errors.errors == 0);
}
my_bitmap_free(&local_set);
DBUG_RETURN(count_errors.errors);
}

Expand Down