MDEV-39405: store the necessary plugin-engines optimizer costs#5077
Open
bsrikanth-mariadb wants to merge 1 commit into
Open
Conversation
bsrikanth-mariadb
force-pushed
the
13.0-MDEV-39405-store-necessary-plugin-engines-costs
branch
from
55e4d81 to
c0d48c6
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enhances the optimizer context replay mechanism by capturing and storing storage engine-specific optimizer costs. It introduces logic to identify relevant storage engines for a query and generates the corresponding global configuration statements. The review feedback correctly identifies several potential memory leaks where hashes are not freed during early returns and suggests optimizations for the cost-storing logic to improve efficiency and safety.
store the necessary plugin-engines optimizer costs that are used by the query into the context, so that the replay server uses the same while computing query cost
bsrikanth-mariadb
force-pushed
the
13.0-MDEV-39405-store-necessary-plugin-engines-costs
branch
from
c0d48c6 to
c77a130
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
store the necessary plugin-engines optimizer costs that are used by the query into the context, so that the replay server uses the same while computing query cost