Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a GitHub Actions workflow that runs on pull requests affecting lists/** to validate that list files follow a parseable, consistent Markdown bullet/link format, and adds initial list files (reviewers, maintainers, committers).
Changes:
- Added a
pull_requestworkflow to detect changed files underlists/and validate bullet/link formatting. - Added
lists/reviewers.md,lists/maintainers.md, andlists/committers.mdwith GitHub profile links.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
.github/workflows/check-lists-format.yml |
Adds the PR-triggered validation workflow for lists/** changes. |
lists/reviewers.md |
Adds the reviewers list in Markdown bullet/link format. |
lists/maintainers.md |
Adds the maintainers list in Markdown bullet/link format. |
lists/committers.md |
Adds the committers list in Markdown bullet/link format. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vuvova
left a comment
There was a problem hiding this comment.
Looks very complex. I thought it'd be a one-liner like
grep '^ *\* \+' lists/*|grep -v ': *\* \+\[[^]]\+\](https://github.com/.*)'
It probably can be simplified. But what is the point? |
|
I know it's doing more or less the same. But it's 40 lines instead of one and the reading speed is generally proportional to the number of lines. It's 40x more lines to read and understand. Only to arrive at conclusion that it's just a hand-coded |
Alright. This is a stylistic thing, but there's no point in arguing if I want the job done. grep | grep -v it is. |
Implement a pull request submission trigger running when files in lists/ are changed to verify if their format is parseable. Co-authored-by: Grok:grok-4.5
Implement a pull request submission trigger running when files in lists/ are changed to verify if their format is parseable.
Note that this PR is based on #1