Repository navigation
Deps: combine Dependabot #44, #46, #52 (AGP 9.4.1, Gradle 9.8.0, AndroidX) - #53
Merged
Merged
Conversation
The three groups cannot land separately: AGP 9.4.1 needs Gradle >= 9.6,
Gradle 9.8 breaks AGP 8.13, Hilt 2.60 needs AGP 9, and the new AndroidX
releases need AGP >= 9.1 and compileSdk 37.
- Gradle 8.13 -> 9.8.0, AGP 8.13.0 -> 9.4.1, Kotlin 2.0.21 -> 2.4.21,
KSP -> 2.3.12, Compose BOM -> 2026.09.00, Hilt -> 2.60.1, Room -> 2.8.5,
core-ktx 1.19.1, navigation 2.10.2, hilt-navigation-compose 1.4.0,
appcompat 1.8.0, coroutines/serialization 1.11.0, Robolectric 4.17.
- Built-in Kotlin: drop org.jetbrains.kotlin.android, move kotlinOptions
to kotlin { compilerOptions }.
- compileSdk 37 (targetSdk stays 36).
- Room schema assets: directories.add instead of deprecated srcDirs.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012dPqf24mFuiYz4kAyALEnG
…teardown - Regenerate the Gradle wrapper for 9.8.0 (jar identical to Dependabot's) and add distributionSha256Sum. - lifecycle 2.8.7 -> 2.11.0: what navigation 2.10 / hilt-navigation 1.4 already resolve, so the catalogue states what ships. - AnalysisViewModelTest failed intermittently under Room 2.8 with "connection is closed": its ViewModels were never cleared, so their Room flows re-queried after @after closed the database. New TrackedViewModels test helper holds them in a ViewModelStore that both ViewModel-over-Room tests clear before closing. - Docs: Robolectric's default SDK follows targetSdk, not compileSdk; mergeDebugUnitTestAssets still absent on AGP 9.4.1 (re-checked); preflight curls the AGP 9.4.1 POM; new CLAUDE.md gotcha for the teardown order. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012dPqf24mFuiYz4kAyALEnG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Supersedes #44, #46 and #52. The three PRs block each other, so none of them can merge alone:
compileSdk37.Versions:
distributionSha256Sumwas added.Build changes:
org.jetbrains.kotlin.android.kotlinOptionsis now a top-levelkotlin { compilerOptions }block. No opt-out properties.compileSdk37.targetSdkstays 36 andminSdkstays 24.assets.directories.add(...)becausesrcDirsis deprecated.Test fix:
AnalysisViewModelTestfailed intermittently under Room 2.8 with "connection is closed". Its ViewModels were never cleared, so their Room flows ran another query after@Afterhad closed the DB. The newTrackedViewModelstest helper puts them in aViewModelStore, and the store is cleared before the DB is closed. The same change is applied toSurpriseMeViewModelTest.Reasoning and sources:
docs/implementation-decisions.md, "Dependabot #44, #46 and #52 combined".How it was checked
lintDebug,testDebugUnitTest,assembleDebuggreen locally: 377 tests, 0 failures, lint 0 errors and 21 warnings. The two ViewModel test classes were also run 3 times in a row, all green. No new tests:TrackedViewModelsis a test helper.REVIEW.md/CLAUDE.mdrules:/code-reviewandarchitecture-reviewer, twice. The fixes are in the second commit.CHANGELOG.md[Unreleased]updated (no user-visible change intended)CLAUDE.md/docs/updated:compileSdk37, the Robolectric gotcha, a new ViewModel teardown gotcha, and the preflight indocs/plan/README.md.Device checks
Open points
androidx.hilt.navigation.compose.hiltViewModel(moved toandroidx.hilt.lifecycle.viewmodel.compose) andMenuAnchorType(nowExposedDropdownMenuAnchorType).ccr-…), not<type>/<what>.Generated by Claude Code