fix(buildkite): shorten Windows MSI packaging paths - #2204
Merged
Conversation
Run packaging in an isolated short workspace and stop on extraction or native packaging failure before publishing. Preserve the checkout MSI artifact location and clean the workspace after restoring the caller. Refs: MSG-268
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AWS Windows checkout makes deeply nested ZIP entries exceed the traditional Windows path limit. Extraction fails and packaging continues with misleading missing-file errors.
This changes only packaging/windows/windows_packager.ps1. It resolves the version in the original checkout, copies the existing packaging helpers and launcher properties into a unique C:\b<GUID> workspace, and performs extraction and staging there. Terminating PowerShell errors and a nonzero native packaging exit stop publishing. The MSI is copied back to packaging/windows/out/win, and finally restores the caller location and removes the owned workspace. Nexus upload behavior is retained.
Validation: static control-flow and upload-block preservation checks passed. The reported entry is 171 characters in extraction and 185 in staging, below 260. PowerShell is unavailable in this environment; Windows execution, actual MSI generation and Nexus upload remain to be verified by rerunning the development MSI pipeline after merge. No Maven run or Java test changes: PowerShell packaging only.
The service account needs permission to create C:\b (the current AWS worker uses the existing administrator configuration). Cleanup failures warn without hiding the original packaging error. No startup, CloudFormation, S3 or messaging protocol changes.
Refs: MSG-268