Skip to content

fix(server): resolve Jenkins unit-test regressions - #2201

Merged
mbuckton merged 3 commits into
developmentfrom
MSG-257-MSG-261-MSG-262-fix-ci-regressions
Sep 9, 2026
Merged

fix(server): resolve Jenkins unit-test regressions#2201
mbuckton merged 3 commits into
developmentfrom
MSG-257-MSG-261-MSG-262-fix-ci-regressions

Conversation

@mbuckton

@mbuckton mbuckton commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • align Stickleback reposition tests with the intended ArduPlane GUIDED + guided-waypoint command sequence
  • validate finite Stickleback mission altitude as supported
  • serialize message-override QoS using the canonical enum name
  • preserve absolute expiry when copying delayed messages by avoiding a second delay addition

Jira

  • MSG-257
  • MSG-261
  • MSG-262

Tests

Targeted tests requested:

  • SticklebackArdupilotUsvModelTest
  • SticklebackArdupilotUsvModelMissionTest
  • MessageOverrideConfigTest
  • MessageOverridesTest
  • MessageBuilderTest

Local Maven execution was attempted but dependency resolution was blocked because repository.mapsmessaging.io is not resolvable from the execution environment. git diff --check passes. Jenkins should provide authoritative verification.

Risk

Low. Stickleback changes are test-only. QoS serialization changes the stored representation from the descriptive enum toString() to the value accepted by valueOf(). Expiry reconstruction changes only message copies and preserves the original absolute expiry instead of extending it by the remaining delay.

@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 174b46fb-6d37-4fd0-9e20-b1ffa42d5eee

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mbuckton
mbuckton merged commit 40da6e3 into development Sep 9, 2026
3 checks passed
@mbuckton
mbuckton deleted the MSG-257-MSG-261-MSG-262-fix-ci-regressions branch September 9, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant